public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/99309] [10/11 Regression] Segmentation fault with __builtin_constant_p usage at -O2
Date: Thu, 15 Apr 2021 09:49:49 +0000	[thread overview]
Message-ID: <bug-99309-4-bozTFuKWvN@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99309-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99309

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #9 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Have WIP patch to attach predicates to buildtin_constant_p and redirect to true
if inliner works out that it is a constat (still relying on late passes to
optimize the if branch well).

>From all the options I can think of this seems best even though it may end up
in relatively rare cases that we do the (very simple) propagation at IPA time
and late optimizations won't.  Without explicitly disabling passes (where I
think this is fine to happen) all testcases we seen so far was of the form that
constant was eventually propagated but only after we folded builtin_constant_p
to false.

Overall it is not possible to assure that builtin_constant_p on memory will
fold to true only if all uses of the memory later in the if branch will ford to
constant since AO has walking limits.

  parent reply	other threads:[~2021-04-15  9:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-28 10:33 [Bug c++/99309] New: " gcc at mailinator dot com
2021-03-01  9:31 ` [Bug c++/99309] [10/11 Regression] " rguenth at gcc dot gnu.org
2021-03-01  9:44 ` jakub at gcc dot gnu.org
2021-03-08 15:45 ` [Bug ipa/99309] " mpolacek at gcc dot gnu.org
2021-03-29 14:07 ` jakub at gcc dot gnu.org
2021-03-31 18:18 ` hubicka at gcc dot gnu.org
2021-03-31 18:29 ` jakub at gcc dot gnu.org
2021-03-31 18:46 ` hubicka at ucw dot cz
2021-04-08 12:02 ` rguenth at gcc dot gnu.org
2021-04-15  9:49 ` hubicka at gcc dot gnu.org [this message]
2022-03-24 13:59 ` [Bug ipa/99309] [10/11/12 " rguenth at gcc dot gnu.org
2022-06-28 10:43 ` [Bug ipa/99309] [10/11/12/13 " jakub at gcc dot gnu.org
2023-07-07 10:39 ` [Bug ipa/99309] [11/12/13/14 " rguenth at gcc dot gnu.org
2023-08-17  0:19 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99309-4-bozTFuKWvN@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).