public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/99352] check_effective_target_sqrt_insn for powerpc is wrong
Date: Wed, 10 Mar 2021 21:41:57 +0000	[thread overview]
Message-ID: <bug-99352-4-7s4CHKhnKS@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99352-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99352

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> ---
commit c60ad1c5fe0249f48362be0f989184ca447f9d17
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date:   Wed Mar 3 20:34:32 2021 +0000

    rs6000: Fix check_effective_target_sqrt_insn (PR99352)

    The previous version returned true for all PowerPC.  This is incorrect.
    We only support floating point square root instructions if a) we support
    floating point instructions at all, and b) we have _ARCH_PPCSQ defined.

    2020-03-09  Segher Boessenkool  <segher@kernel.crashing.org>

    gcc/testsuite/
        * lib/target-supports.exp (check_effective_target_powerpc_sqrt): New.
        (check_effective_target_sqrt_insn): Use it.

      parent reply	other threads:[~2021-03-10 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 19:34 [Bug testsuite/99352] New: " segher at gcc dot gnu.org
2021-03-02 19:35 ` [Bug testsuite/99352] " segher at gcc dot gnu.org
2021-03-04 14:36 ` hp at gcc dot gnu.org
2021-03-04 15:59 ` segher at gcc dot gnu.org
2021-03-10 21:41 ` segher at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99352-4-7s4CHKhnKS@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).