public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/99352] New: check_effective_target_sqrt_insn for powerpc is wrong
@ 2021-03-02 19:34 segher at gcc dot gnu.org
2021-03-02 19:35 ` [Bug testsuite/99352] " segher at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: segher at gcc dot gnu.org @ 2021-03-02 19:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99352
Bug ID: 99352
Summary: check_effective_target_sqrt_insn for powerpc is wrong
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: testsuite
Assignee: unassigned at gcc dot gnu.org
Reporter: segher at gcc dot gnu.org
Target Milestone: ---
It just just says
[istarget powerpc*-*-*]
but it should test whether the preprocessor symbol "_ARCH_PPCSQ" is defined.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/99352] check_effective_target_sqrt_insn for powerpc is wrong
2021-03-02 19:34 [Bug testsuite/99352] New: check_effective_target_sqrt_insn for powerpc is wrong segher at gcc dot gnu.org
@ 2021-03-02 19:35 ` segher at gcc dot gnu.org
2021-03-04 14:36 ` hp at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: segher at gcc dot gnu.org @ 2021-03-02 19:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99352
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Target| |powerpc*-*-*
Last reconfirmed| |2021-03-02
Assignee|unassigned at gcc dot gnu.org |segher at gcc dot gnu.org
Status|UNCONFIRMED |ASSIGNED
--- Comment #1 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Mine.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/99352] check_effective_target_sqrt_insn for powerpc is wrong
2021-03-02 19:34 [Bug testsuite/99352] New: check_effective_target_sqrt_insn for powerpc is wrong segher at gcc dot gnu.org
2021-03-02 19:35 ` [Bug testsuite/99352] " segher at gcc dot gnu.org
@ 2021-03-04 14:36 ` hp at gcc dot gnu.org
2021-03-04 15:59 ` segher at gcc dot gnu.org
2021-03-10 21:41 ` segher at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: hp at gcc dot gnu.org @ 2021-03-04 14:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99352
Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hp at gcc dot gnu.org
--- Comment #2 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Have a look at check_effective_target_hard_float or more simple
check_effective_target_popcount.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/99352] check_effective_target_sqrt_insn for powerpc is wrong
2021-03-02 19:34 [Bug testsuite/99352] New: check_effective_target_sqrt_insn for powerpc is wrong segher at gcc dot gnu.org
2021-03-02 19:35 ` [Bug testsuite/99352] " segher at gcc dot gnu.org
2021-03-04 14:36 ` hp at gcc dot gnu.org
@ 2021-03-04 15:59 ` segher at gcc dot gnu.org
2021-03-10 21:41 ` segher at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: segher at gcc dot gnu.org @ 2021-03-04 15:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99352
--- Comment #3 from Segher Boessenkool <segher at gcc dot gnu.org> ---
rs6000 has check_effective_target_powerpc_fprs already (with slightly
different semantics).
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug testsuite/99352] check_effective_target_sqrt_insn for powerpc is wrong
2021-03-02 19:34 [Bug testsuite/99352] New: check_effective_target_sqrt_insn for powerpc is wrong segher at gcc dot gnu.org
` (2 preceding siblings ...)
2021-03-04 15:59 ` segher at gcc dot gnu.org
@ 2021-03-10 21:41 ` segher at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: segher at gcc dot gnu.org @ 2021-03-10 21:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99352
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> ---
commit c60ad1c5fe0249f48362be0f989184ca447f9d17
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date: Wed Mar 3 20:34:32 2021 +0000
rs6000: Fix check_effective_target_sqrt_insn (PR99352)
The previous version returned true for all PowerPC. This is incorrect.
We only support floating point square root instructions if a) we support
floating point instructions at all, and b) we have _ARCH_PPCSQ defined.
2020-03-09 Segher Boessenkool <segher@kernel.crashing.org>
gcc/testsuite/
* lib/target-supports.exp (check_effective_target_powerpc_sqrt): New.
(check_effective_target_sqrt_insn): Use it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-10 21:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 19:34 [Bug testsuite/99352] New: check_effective_target_sqrt_insn for powerpc is wrong segher at gcc dot gnu.org
2021-03-02 19:35 ` [Bug testsuite/99352] " segher at gcc dot gnu.org
2021-03-04 14:36 ` hp at gcc dot gnu.org
2021-03-04 15:59 ` segher at gcc dot gnu.org
2021-03-10 21:41 ` segher at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).