public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vmakarov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99422] [11 Regression] ICE in extract_constrain_insn building glibc pthread_create
Date: Sun, 07 Mar 2021 19:49:45 +0000	[thread overview]
Message-ID: <bug-99422-4-zYDZuxlazs@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99422-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99422

--- Comment #7 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #2)
> I see the function is called before selecting a particular alternative, so
> perhaps it means to care only about constraints like "X" and "" and not say
> that mixed with other constraints etc.
> But, shouldn't the code at least skip the =, +, &, % and whitespace from the
> start?  What about other modifiers (the various disparage slightly etc.
> chars)?
> And only consider as empty constraint if after those skips constraint is ""?
> Not really sure if ",,," constraint is valid...
> And, regarding of Eric's change to handle "X" that way, does that really
> apply just to MEM and not SUBREG of MEM too?

Yes.  It seems my bad job on reviewing Richard Sandiford's patch 777e635f1a6c. 
Before this patch constraint string was checked only for 'p' which can not have
modifiers (although spaces are still possible).

I am afraid that fixing this mess can result in new failures.  But we should do
this anyway.

  parent reply	other threads:[~2021-03-07 19:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06  1:31 [Bug target/99422] New: " jsm28 at gcc dot gnu.org
2021-03-06  9:51 ` [Bug target/99422] " jakub at gcc dot gnu.org
2021-03-06  9:51 ` jakub at gcc dot gnu.org
2021-03-06 10:08 ` jakub at gcc dot gnu.org
2021-03-06 18:57 ` dcb314 at hotmail dot com
2021-03-07  2:27 ` pinskia at gcc dot gnu.org
2021-03-07  2:28 ` pinskia at gcc dot gnu.org
2021-03-07 19:01 ` vmakarov at gcc dot gnu.org
2021-03-07 19:49 ` vmakarov at gcc dot gnu.org [this message]
2021-03-07 20:34 ` pinskia at gcc dot gnu.org
2021-03-07 21:00 ` pinskia at gcc dot gnu.org
2021-03-08 14:26 ` cvs-commit at gcc dot gnu.org
2021-03-08 14:31 ` vmakarov at gcc dot gnu.org
2021-03-08 18:53 ` ro at gcc dot gnu.org
2021-03-08 18:58 ` vmakarov at gcc dot gnu.org
2021-03-08 19:05 ` vmakarov at gcc dot gnu.org
2021-03-08 19:33 ` gerald at pfeifer dot com
2021-03-08 20:45 ` raj.khem at gmail dot com
2021-03-08 21:16 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-03-10 14:06 ` ro at gcc dot gnu.org
2021-03-10 16:10 ` ebotcazou at gcc dot gnu.org
2021-03-10 18:46 ` vmakarov at gcc dot gnu.org
2021-03-10 21:16 ` cvs-commit at gcc dot gnu.org
2021-03-10 21:21 ` vmakarov at gcc dot gnu.org
2021-03-11  9:44 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-03-11 10:13 ` ebotcazou at gcc dot gnu.org
2021-03-11 19:11 ` vmakarov at gcc dot gnu.org
2021-03-11 21:34 ` vmakarov at gcc dot gnu.org
2021-03-11 23:38 ` ebotcazou at gcc dot gnu.org
2021-03-12 17:52 ` cvs-commit at gcc dot gnu.org
2021-03-16 10:36 ` jakub at gcc dot gnu.org
2021-03-16 19:26 ` jakub at gcc dot gnu.org
2021-03-18 19:59 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99422-4-zYDZuxlazs@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).