public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/99447] [11 Regression] ICE (segfault) in lookup_page_table_entry
Date: Wed, 17 Mar 2021 13:30:00 +0000	[thread overview]
Message-ID: <bug-99447-4-ZbvDBFLFkb@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99447-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99447

--- Comment #11 from Jan Hubicka <hubicka at ucw dot cz> ---
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99447
> 
> --- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
> So like this.
> 
> diff --git a/gcc/cgraph.c b/gcc/cgraph.c
> index 80140757d16..447d9a920f7 100644
> --- a/gcc/cgraph.c
> +++ b/gcc/cgraph.c
> @@ -1854,6 +1854,9 @@ cgraph_node::release_body (bool keep_arguments)
>       needed to emit debug info later.  */
>    if (!used_as_abstract_origin && DECL_INITIAL (decl))
>      DECL_INITIAL (decl) = error_mark_node;
> +  /* Zap references to call stmts of our body.  */
> +  for (cgraph_edge *e = callees; e; e = e->next_callee)
> +    e->call_stmt = NULL;

Looks good but will also need to warlk indirect calls.
However I wonder in what situations it makes sense to release body but
keep cgraph edges?

Honza
>    release_function_body (decl);
>    if (lto_file_data)
>      {
> 
> -- 
> You are receiving this mail because:
> You are on the CC list for the bug.

  parent reply	other threads:[~2021-03-17 13:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 10:35 [Bug lto/99447] New: " doko at debian dot org
2021-03-07 10:41 ` [Bug lto/99447] " doko at debian dot org
2021-03-07 11:17 ` pinskia at gcc dot gnu.org
2021-03-08  8:46 ` marxin at gcc dot gnu.org
2021-03-08  9:01 ` rguenth at gcc dot gnu.org
2021-03-08 10:57 ` doko at debian dot org
2021-03-17 12:18 ` rguenth at gcc dot gnu.org
2021-03-17 12:20 ` rguenth at gcc dot gnu.org
2021-03-17 12:33 ` rguenth at gcc dot gnu.org
2021-03-17 12:38 ` rguenth at gcc dot gnu.org
2021-03-17 12:39 ` rguenth at gcc dot gnu.org
2021-03-17 13:30 ` hubicka at ucw dot cz [this message]
2021-03-25 15:27 ` marxin at gcc dot gnu.org
2021-03-26 11:03 ` doko at gcc dot gnu.org
2021-03-26 11:18 ` [Bug ipa/99447] " rguenth at gcc dot gnu.org
2021-03-29 18:20 ` hubicka at gcc dot gnu.org
2021-03-29 21:45 ` hubicka at gcc dot gnu.org
2021-03-30  7:20 ` rguenth at gcc dot gnu.org
2021-03-30  8:49 ` hubicka at gcc dot gnu.org
2021-03-30  9:00 ` hubicka at gcc dot gnu.org
2021-03-30 12:16 ` hubicka at gcc dot gnu.org
2021-03-31  9:18 ` doko at debian dot org
2021-03-31  9:18 ` doko at gcc dot gnu.org
2021-03-31  9:19 ` doko at gcc dot gnu.org
2021-03-31  9:33 ` hubicka at ucw dot cz
2021-03-31  9:35 ` cvs-commit at gcc dot gnu.org
2021-03-31  9:39 ` hubicka at ucw dot cz
2021-03-31 18:10 ` cvs-commit at gcc dot gnu.org
2021-03-31 18:12 ` hubicka at gcc dot gnu.org
2021-04-01 12:50 ` doko at debian dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99447-4-ZbvDBFLFkb@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).