[Bug c++/99451] New: [plugin] cannot enable dumps for plugin passes

[Bug c++/99451] New: [plugin] cannot enable dumps for plugin passes

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99451

            Bug ID: 99451
           Summary: [plugin] cannot enable dumps for plugin passes
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nathan at gcc dot gnu.org
  Target Milestone: ---

Created attachment 50324
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50324&action=edit
patch

the -fdump-FOO-BAR options are parsed before plugins have been initialized,
this means that one cannot name a pass created with a plugin.

Here's a patch to defer the dump option processing until later (we cannot just
swap the order, as the plugin options themselves need parsing before we
initialize the plugins).

-fdump-FOO-all will enable the dump, so we have a workaround

I don't think this is a regression, so stage 1 I guess?

[Bug c++/99451] [plugin] cannot enable specific dump for plugin passes

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99451

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Yeah.

[Bug c++/99451] [plugin] cannot enable specific dump for plugin passes

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99451

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:97a36b466ba1420210294f0a1dd7002054ba3b7e

commit r14-1004-g97a36b466ba1420210294f0a1dd7002054ba3b7e
Author: Nathan Sidwell <nathan@acm.org>
Date:   Wed May 17 19:27:13 2023 -0400

    Allow plugin dumps

    Defer dump option parsing until plugins are initialized.  This allows one
to
    use plugin names for dumps.

            PR other/99451
            gcc/
            * opts.h (handle_deferred_dump_options): Declare.
            * opts-global.cc (handle_common_deferred_options): Do not handle
            dump options here.
            (handle_deferred_dump_options): New.
            * toplev.cc (toplev::main): Call it after plugin init.