public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/99459] [11 Regression] Many coroutines regressions on armv7hl-linux-gnueabi
Date: Mon, 08 Mar 2021 09:59:43 +0000 [thread overview]
Message-ID: <bug-99459-4-7GBwdVM6lh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99459-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99459
--- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #4)
> So perhaps:
> 2021-03-08 Jakub Jelinek <jakub@redhat.com>
>
> PR c++/99459
> * coroutines.cc (build_co_await): Look through NOP_EXPRs in
> build_special_member_call return value to find the CALL_EXPR.
>
> --- gcc/cp/coroutines.cc.jj 2021-03-05 21:51:48.671185716 +0100
> +++ gcc/cp/coroutines.cc 2021-03-08 10:53:13.187959339 +0100
> @@ -868,6 +868,8 @@ build_co_await (location_t loc, tree a,
> = build_special_member_call (a, complete_dtor_identifier,
> NULL, a_type, LOOKUP_NORMAL,
> tf_none);
> + if (dummy && CONVERT_EXPR_P (dummy))
> + dummy = TREE_OPERAND (dummy, 0);
> dummy = dummy ? TREE_OPERAND (CALL_EXPR_FN (dummy), 0)
> : NULL_TREE;
> if (dummy && coro_diagnose_throwing_fn (dummy))
> @@ -1031,6 +1033,8 @@ build_co_await (location_t loc, tree a,
> = build_special_member_call (e_proxy, complete_dtor_identifier,
> NULL, o_type, LOOKUP_NORMAL,
> tf_none);
> + if (dummy && CONVERT_EXPR_P (dummy))
> + dummy = TREE_OPERAND (dummy, 0);
> dummy = dummy ? TREE_OPERAND (CALL_EXPR_FN (dummy), 0)
> : NULL_TREE;
> if (dummy && coro_diagnose_throwing_fn (dummy))
>
> ?
looks reasonable to me - but I have no way to test it at present.
next prev parent reply other threads:[~2021-03-08 9:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 9:26 [Bug c++/99459] New: " jakub at gcc dot gnu.org
2021-03-08 9:30 ` [Bug c++/99459] " clyon at gcc dot gnu.org
2021-03-08 9:35 ` jakub at gcc dot gnu.org
2021-03-08 9:54 ` jakub at gcc dot gnu.org
2021-03-08 9:54 ` jakub at gcc dot gnu.org
2021-03-08 9:55 ` jakub at gcc dot gnu.org
2021-03-08 9:56 ` iains at gcc dot gnu.org
2021-03-08 9:59 ` iains at gcc dot gnu.org [this message]
2021-03-08 10:01 ` rguenth at gcc dot gnu.org
2021-03-08 10:03 ` iains at gcc dot gnu.org
2021-03-08 10:08 ` jakub at gcc dot gnu.org
2021-03-08 14:27 ` iains at gcc dot gnu.org
2021-03-08 14:38 ` jakub at gcc dot gnu.org
2021-03-09 11:55 ` jakub at gcc dot gnu.org
2021-03-09 15:46 ` cvs-commit at gcc dot gnu.org
2021-03-09 15:48 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-99459-4-7GBwdVM6lh@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).