public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/99519] New: [OpenMP] PRIVATE/FIRSTPRIVATE with CLASS / polymorphic list items
@ 2021-03-10 15:27 burnus at gcc dot gnu.org
  2021-05-24 15:10 ` [Bug fortran/99519] " burnus at gcc dot gnu.org
  0 siblings, 1 reply; 2+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-03-10 15:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99519

            Bug ID: 99519
           Summary: [OpenMP] PRIVATE/FIRSTPRIVATE with CLASS / polymorphic
                    list items
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code, openmp
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
  Target Milestone: ---

Follow-up to PR86470.

Class variables need some special handling for PRIVATE/FIRSTPRIVATE in
data-sharing constructs like:

class(*), allocatable ::  var1, var2
...
!$omp parallel private(var1) firstprivate(var2)
  ...
!$omp end parallel


The following patch handles FIRSTPRIVATE:
  https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566529.html

Missing:
* PRIVATE - which causes still ICEs, even though not for PR86470.
  → use dynamic type of var, apply default initializers
* Polymorphic arrays not supported by FIRSTPRIVATE patch
* Check that for TYPE, the default initializer is applied
  - what about the finalizer?

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug fortran/99519] [OpenMP] PRIVATE/FIRSTPRIVATE with CLASS / polymorphic list items
  2021-03-10 15:27 [Bug fortran/99519] New: [OpenMP] PRIVATE/FIRSTPRIVATE with CLASS / polymorphic list items burnus at gcc dot gnu.org
@ 2021-05-24 15:10 ` burnus at gcc dot gnu.org
  0 siblings, 0 replies; 2+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-05-24 15:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99519

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The patch was now committed as:

commit r12-1016-g0e3b3b77e13cac764a135a7118613c47686e0a62
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Mon May 24 16:50:51 2021 +0200

    OpenMP/Fortran: Handle polymorphic scalars in data-sharing FIRSTPRIVATE
[PR86470]

(The PR is the original PR instead of the one of this follow-up PR.)

To be done:

Missing:
* PRIVATE - which causes still ICEs, even though not for PR86470.
  → use dynamic type of var, apply default initializers
* Polymorphic arrays not supported by FIRSTPRIVATE patch
* Check that for TYPE (the patch was for CLASS),
  the default initializer is applied - and what about the finalizer?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-24 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 15:27 [Bug fortran/99519] New: [OpenMP] PRIVATE/FIRSTPRIVATE with CLASS / polymorphic list items burnus at gcc dot gnu.org
2021-05-24 15:10 ` [Bug fortran/99519] " burnus at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).