[Bug fortran/99545] New: [11.0 regression] ICE in gfc_trans_assignment

[Bug fortran/99545] New: [11.0 regression] ICE in gfc_trans_assignment

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

            Bug ID: 99545
           Summary: [11.0 regression] ICE in gfc_trans_assignment
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: juergen.reuter at desy dot de
  Target Milestone: ---

This regression must have been introduced between Dec 6, 2020 and now, sorry,
no better containment at the moment:
ommands.f90:5466:60:

 5466 |           allocate (range_int_t :: cmd%range (cmd%n_values))
      |                                                            1
internal compiler error: in gfc_trans_assignment_1, at
fortran/trans-expr.c:11247
This is only a problem when compiling with full debug flags, i.e. 
-O0 -fbacktrace -fcheck=all -Wconversion -Wconversion-extra -Wsurprising

A short reproducer will follow but for those of you that know the Whizard
project, https://whizard.hepforge.org could check this already, take the last
tarball 3.0.0beta or 2.8.5.

[Bug fortran/99545] [11.0 regression] ICE in gfc_trans_assignment

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #1 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Obviously, it would be great if that regression doesn't make it into the 11.1
official release. [As it is with debug flags, that would be less dramatic than
with default flags]

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |11.0
            Summary|[11.0 regression] ICE in    |[11 Regression] ICE in
                   |gfc_trans_assignment        |gfc_trans_assignment
           Keywords|                            |ice-on-valid-code

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2021-03-11
     Ever confirmed|0                           |1

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Please provide a reproducer.

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #3 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Created attachment 50362
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50362&action=edit
First (large) reproducer to play with, reducing atm

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
             Status|WAITING                     |ASSIGNED

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Good, I can reproduce that now. I'm reducing that right now (starting with 2MB
of .f90 file).

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #5 from Jürgen Reuter <juergen.reuter at desy dot de> ---
I'm also reducing it right now.

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #6 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Voila, here is a short reproducer:
module commands

  implicit none
  private

  type, abstract :: range_t
     integer :: step_mode = 0
     integer :: n_step = 0
  end type range_t

  type, extends (range_t) :: range_int_t
     integer :: i_step = 0
  end type range_int_t

  type, extends (range_t) :: range_real_t
     real :: lr_step = 0
end type range_real_t

  type :: cmd_scan_t
     private
     class(range_t), dimension(:), allocatable :: range
   contains
     procedure :: compile => cmd_scan_compile
  end type cmd_scan_t

contains

  subroutine cmd_scan_compile (cmd)
    class(cmd_scan_t), intent(inout) :: cmd
    allocate (range_int_t :: cmd%range (3))
    allocate (range_real_t :: cmd%range (3))
  end subroutine cmd_scan_compile

end module commands

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #7 from Jürgen Reuter <juergen.reuter at desy dot de> ---
It actuallys is the -fcheck=mem part that triggers the ICE.

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11 Regression] ICE in      |[11 Regression] ICE in
                   |gfc_trans_assignment        |gfc_trans_assignment since
                   |                            |r11-6253-gce8dcc9105cbd404
                 CC|                            |pault at gcc dot gnu.org

--- Comment #8 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-6253-gce8dcc9105cbd404.

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|marxin at gcc dot gnu.org          |pault at gcc dot gnu.org

--- Comment #9 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 50386
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50386&action=edit
Fix for the PR

Juergen,

Thanks for the report and the reduction.

r11-6253-gce8dcc9105cbd404 exposed at error in gfc_trans_allocate. What is
manifestly an initialization assignment was not being flagged as such.

I will commit as obvious later on today.

Regards

Paul

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:21ced2776a117924e52f6aab8b41afb613fef0e7

commit r11-7666-g21ced2776a117924e52f6aab8b41afb613fef0e7
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Mon Mar 15 09:32:52 2021 +0000

    Fortran: Fix problem with allocate initialization [PR99545].

    2021-03-15  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran/ChangeLog

            PR fortran/99545
            * trans-stmt.c (gfc_trans_allocate): Mark the initialization
            assignment by setting init_flag.

    gcc/testsuite/ChangeLog

            PR fortran/99545
            * gfortran.dg/pr99545.f90: New test.

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:62bba614ffadb593baaaf13c881874ee96c7b7ce

commit r10-9442-g62bba614ffadb593baaaf13c881874ee96c7b7ce
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Mon Mar 15 09:32:52 2021 +0000

    Fortran: Fix problem with allocate initialization [PR99545].

    2021-03-15  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran/ChangeLog

            PR fortran/99545
            * trans-stmt.c (gfc_trans_allocate): Mark the initialization
            assignment by setting init_flag.

    gcc/testsuite/ChangeLog

            PR fortran/99545
            * gfortran.dg/pr99545.f90: New test.

    (cherry picked from commit 21ced2776a117924e52f6aab8b41afb613fef0e7)

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:b4f86a21263b8e731de68a78862e5c480ef3d160

commit r9-9284-gb4f86a21263b8e731de68a78862e5c480ef3d160
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Mon Mar 15 09:32:52 2021 +0000

    Fortran: Fix problem with allocate initialization [PR99545].

    2021-03-15  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran/ChangeLog

            PR fortran/99545
            * trans-stmt.c (gfc_trans_allocate): Mark the initialization
            assignment by setting init_flag.

    gcc/testsuite/ChangeLog

            PR fortran/99545
            * gfortran.dg/pr99545.f90: New test.

    (cherry picked from commit 21ced2776a117924e52f6aab8b41afb613fef0e7)

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #13 from Jürgen Reuter <juergen.reuter at desy dot de> ---
I confirm that with that patch our code compiles again, however, more or less
all functionality fails because of runtime errors about 
Fortran runtime error: Pointer actual argument '<some_name>' is not associated.
Not sure whether this is related. Shall I open another PR? 
Working on a reproducer for that problem.

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #14 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Jürgen Reuter from comment #13)
> I confirm that with that patch our code compiles again, however, more or
> less all functionality fails because of runtime errors about 
> Fortran runtime error: Pointer actual argument '<some_name>' is not
> associated.
> Not sure whether this is related. Shall I open another PR? 
> Working on a reproducer for that problem.

Please work on a reproducer. I cannot quite see that the new problem is related
but keep this PR open for now.

The test below works, so the correct functionality of allocate is retained.
Your original reproducer no longer ICEs and gives the correct runtime error.

Cheers

Paul

! { dg-do compile }
! { dg-options "-fcheck=mem" }
!
! Test the fix for PR99545, in which the allocate statements caused an ICE.
!
! Contributed by Juergen Reuter  <juergen.reuter@desy.de>
!
module commands
  implicit none
!  private

  type, abstract :: range_t
     integer :: step_mode = 0
     integer :: n_step = 0
  end type range_t

  type, extends (range_t) :: range_int_t
     integer :: i_step = 1
  end type range_int_t

  type, extends (range_t) :: range_real_t
     real :: lr_step = 2.0
end type range_real_t

  type :: cmd_scan_t
!     private
     class(range_t), dimension(:), allocatable :: range
   contains
     procedure :: compile => cmd_scan_compile
  end type cmd_scan_t

contains

  subroutine cmd_scan_compile (cmd, sw)
    class(cmd_scan_t), intent(inout) :: cmd
    integer :: sw

    if (allocated (cmd%range)) deallocate (cmd%range)
    if (sw .eq. 1) then
      allocate (range_int_t :: cmd%range (3))
    else
      allocate (range_real_t :: cmd%range (3))
    end if
  end subroutine cmd_scan_compile

end module commands

  use commands
  class(cmd_scan_t), allocatable :: x
  integer :: i
  allocate (x)
  do i = 1, 2
    call x%compile (i)
    select type (y => x%range)
      type is (range_int_t)
        print *, y%i_step
      type is (range_real_t)
        print *, y%lr_step
    end select
  end do
end

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

--- Comment #15 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Paul, thanks for the quick response, I opened a new one, PR99602. Please close
this one.

[Bug fortran/99545] [11 Regression] ICE in gfc_trans_assignment since r11-6253-gce8dcc9105cbd404

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99545

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #16 from Paul Thomas <pault at gcc dot gnu.org> ---
Closed as fixed on all three branches.

Paul