public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug go/99553] New: libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ?
@ 2021-03-11 15:55 dcb314 at hotmail dot com
2021-03-11 23:11 ` [Bug go/99553] " ian at airs dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: dcb314 at hotmail dot com @ 2021-03-11 15:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99553
Bug ID: 99553
Summary: libgo/misc/cgo/testcarchive/testdata/main_unix.c:39:
suspicious compare ?
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: go
Assignee: ian at airs dot com
Reporter: dcb314 at hotmail dot com
CC: cmang at google dot com
Target Milestone: ---
Static analyzer cppcheck says
trunk.git/libgo/misc/cgo/testcarchive/testdata/main_unix.c:39:22: warning:
String literal compared with variable 'getenv("GCCGO")'. Did you intend to use
strcmp() instead? [literalWithCharPtrCompare]
Source code is
if (getenv("GCCGO") == "" && (osa.sa_flags&SA_ONSTACK) == 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug go/99553] libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ? 2021-03-11 15:55 [Bug go/99553] New: libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ? dcb314 at hotmail dot com @ 2021-03-11 23:11 ` ian at airs dot com 2021-03-13 4:06 ` cvs-commit at gcc dot gnu.org 2021-03-13 4:29 ` ian at airs dot com 2 siblings, 0 replies; 4+ messages in thread From: ian at airs dot com @ 2021-03-11 23:11 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99553 Ian Lance Taylor <ian at airs dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Last reconfirmed| |2021-03-11 Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #1 from Ian Lance Taylor <ian at airs dot com> --- Thanks. Sent https://golang.org/cl/300993 to fix this in the upstream sources. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug go/99553] libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ? 2021-03-11 15:55 [Bug go/99553] New: libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ? dcb314 at hotmail dot com 2021-03-11 23:11 ` [Bug go/99553] " ian at airs dot com @ 2021-03-13 4:06 ` cvs-commit at gcc dot gnu.org 2021-03-13 4:29 ` ian at airs dot com 2 siblings, 0 replies; 4+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2021-03-13 4:06 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99553 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Ian Lance Taylor <ian@gcc.gnu.org>: https://gcc.gnu.org/g:3972574f11e5d49f12ad88faf2346f77ffc6e523 commit r11-7655-g3972574f11e5d49f12ad88faf2346f77ffc6e523 Author: Ian Lance Taylor <iant@golang.org> Date: Fri Mar 12 19:17:09 2021 -0800 misc/cgo/testcarchive: don't use == for string equality in C code Backport of https://golang.org/cl/300993. For PR go/99553 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/301458 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug go/99553] libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ? 2021-03-11 15:55 [Bug go/99553] New: libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ? dcb314 at hotmail dot com 2021-03-11 23:11 ` [Bug go/99553] " ian at airs dot com 2021-03-13 4:06 ` cvs-commit at gcc dot gnu.org @ 2021-03-13 4:29 ` ian at airs dot com 2 siblings, 0 replies; 4+ messages in thread From: ian at airs dot com @ 2021-03-13 4:29 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99553 Ian Lance Taylor <ian at airs dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #3 from Ian Lance Taylor <ian at airs dot com> --- Thanks, fixed. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-13 4:29 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-11 15:55 [Bug go/99553] New: libgo/misc/cgo/testcarchive/testdata/main_unix.c:39: suspicious compare ? dcb314 at hotmail dot com 2021-03-11 23:11 ` [Bug go/99553] " ian at airs dot com 2021-03-13 4:06 ` cvs-commit at gcc dot gnu.org 2021-03-13 4:29 ` ian at airs dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).