public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/99576] [coroutines] destructor of a temporary called too early within co_await expression Date: Wed, 30 Nov 2022 11:47:25 +0000 [thread overview] Message-ID: <bug-99576-4-SzlbCRhV29@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99576-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99576 --- Comment #13 from Iain Sandoe <iains at gcc dot gnu.org> --- (In reply to Adrian Perl from comment #12) > I have sent the patch and tests to gcc-patches@gcc.gnu.org As noted there, the patch causes regressions in more complex library code (e.g. some tests in folly) where CONSTRUCTOR trees might have nested await expressions. I mentioned that the real problem is to determine if a temporary should be promoted - and, in the case of PR95736, the issue is that we promote a temporary for a target expression that is subsequently elided; we can see this clearly if we print the object addresses in the test case: START TASK Foo() 0x600001004071 IN LAMBDA ~Foo() 0x600001004070 << corresponds to the elided target expression. ~Foo() 0x600001004071 so this: diff --git a/gcc/cp/coroutines.cc b/gcc/cp/coroutines.cc index ce7cf971e03..1bad509233c 100644 --- a/gcc/cp/coroutines.cc +++ b/gcc/cp/coroutines.cc @@ -2830,6 +2830,7 @@ find_interesting_subtree (tree *expr_p, int *dosub, void *d) } } else if (tmp_target_expr_p (expr) + && !TARGET_EXPR_ELIDING_P (expr) && !p->temps_used->contains (expr)) { p->entry = expr_p; fixes that specific problem - but regresses other test cases (no detailed analysis yet). Needs more thought ....
next prev parent reply other threads:[~2022-11-30 11:47 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-13 13:54 [Bug c++/99576] New: [coroutines] desctructor " lemourin at gmail dot com 2021-05-14 16:21 ` [Bug c++/99576] [coroutines] destructor " nilsgladitz at gmail dot com 2021-05-15 12:31 ` nilsgladitz at gmail dot com 2021-06-10 14:14 ` davidledger at live dot com.au 2021-06-23 8:54 ` victor.burckel at gmail dot com 2021-10-01 19:57 ` iains at gcc dot gnu.org 2022-11-25 11:50 ` adrian.perl at web dot de 2022-11-25 15:13 ` iains at gcc dot gnu.org 2022-11-26 16:28 ` adrian.perl at web dot de 2022-11-26 16:40 ` iains at gcc dot gnu.org 2022-11-27 14:24 ` adrian.perl at web dot de 2022-11-27 15:42 ` iains at gcc dot gnu.org 2022-11-27 16:08 ` adrian.perl at web dot de 2022-11-28 19:13 ` adrian.perl at web dot de 2022-11-30 11:47 ` iains at gcc dot gnu.org [this message] 2022-11-30 23:38 ` iains at gcc dot gnu.org 2022-12-02 20:54 ` iains at gcc dot gnu.org 2022-12-04 10:41 ` cvs-commit at gcc dot gnu.org 2023-07-07 9:32 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99576-4-SzlbCRhV29@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).