public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/99576] [coroutines] destructor of a temporary called too early within co_await expression Date: Fri, 25 Nov 2022 15:13:17 +0000 [thread overview] Message-ID: <bug-99576-4-mrcPprCQOC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99576-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99576 --- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> --- (In reply to Adrian Perl from comment #5) > Created attachment 53963 [details] thanks for the analysis and the patch. > Patch: > diff --git a/gcc/cp/coroutines.cc b/gcc/cp/coroutines.cc > index 01a3e831ee5..349b68ea239 100644 > --- a/gcc/cp/coroutines.cc > +++ b/gcc/cp/coroutines.cc > @@ -2684,6 +2684,10 @@ find_interesting_subtree (tree *expr_p, int *dosub, > void *d) > return expr; > } > } > + else if (TREE_CODE(expr) == CONSTRUCTOR) > + { > + *dosub = 0; /* We don't need to consider this any further. */ > + } small nit - the { } are not needed here ^ > else if (tmp_target_expr_p (expr) > && !p->temps_used->contains (expr)) > { > -- > 2.34.1 Your reasoning (I know that several of the outstanding issues are related to 'promotion' of temporaries to the frame) and the patch seem reasonable. Have you bootstrapped the compiler with the changes and run the whole of the testsuite? (I do agree that this change should only affect coroutines, but we still do the full check too). The test-cases would need to be added to the gcc/testsuite/g++.dg/coroutines (with names that reflect the PRs that they test). once you have things to that stage, then please post the patch to gcc-patches@gcc.gnu.org (along with the test cases added), and we can go from there.
next prev parent reply other threads:[~2022-11-25 15:13 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-13 13:54 [Bug c++/99576] New: [coroutines] desctructor " lemourin at gmail dot com 2021-05-14 16:21 ` [Bug c++/99576] [coroutines] destructor " nilsgladitz at gmail dot com 2021-05-15 12:31 ` nilsgladitz at gmail dot com 2021-06-10 14:14 ` davidledger at live dot com.au 2021-06-23 8:54 ` victor.burckel at gmail dot com 2021-10-01 19:57 ` iains at gcc dot gnu.org 2022-11-25 11:50 ` adrian.perl at web dot de 2022-11-25 15:13 ` iains at gcc dot gnu.org [this message] 2022-11-26 16:28 ` adrian.perl at web dot de 2022-11-26 16:40 ` iains at gcc dot gnu.org 2022-11-27 14:24 ` adrian.perl at web dot de 2022-11-27 15:42 ` iains at gcc dot gnu.org 2022-11-27 16:08 ` adrian.perl at web dot de 2022-11-28 19:13 ` adrian.perl at web dot de 2022-11-30 11:47 ` iains at gcc dot gnu.org 2022-11-30 23:38 ` iains at gcc dot gnu.org 2022-12-02 20:54 ` iains at gcc dot gnu.org 2022-12-04 10:41 ` cvs-commit at gcc dot gnu.org 2023-07-07 9:32 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99576-4-mrcPprCQOC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).