[Bug c++/99643] New: internal compiler error in build_over_call, involving array new and copy elision

[Bug c++/99643] New: internal compiler error in build_over_call, involving array new and copy elision

[ensadc at mailnesia dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

            Bug ID: 99643
           Summary: internal compiler error in build_over_call, involving
                    array new and copy elision
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ensadc at mailnesia dot com
  Target Milestone: ---

https://godbolt.org/z/8TWG9d

====
struct Foo {};
Foo get_foo();

int main() {
    new Foo[1]{get_foo()};
}

====
<source>: In function 'int main()':
<source>:5:25: internal compiler error: in build_over_call, at cp/call.c:9360
    5 |     new Foo[1]{get_foo()};
      |                         ^
0x1cfa0d9 internal_error(char const*, ...)
        ???:0
0x6ba797 fancy_abort(char const*, int, char const*)
        ???:0
0x6df07c build_new_method_call(...)
        ???:0
0x6e07e0 build_special_member_call(...)
        ???:0
0x76a7cf ocp_convert(...)
        ???:0
0x7f46a8 build_aggr_init(tree_node*, tree_node*, int, int)
        ???:0
0x7f30c0 build_vec_init(...)
        ???:0
0x7f8051 build_new(...)
        ???:0
0x8e12dd c_parse_file()
        ???:0
0xa5f8d2 c_common_parse_file()
        ???:0
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
====

This seems like a regression from GCC 10.

[Bug c++/99643] [8/9/10/11 Regression] internal compiler error in build_over_call, involving array new and copy elision

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
             Status|UNCONFIRMED                 |NEW
   Target Milestone|---                         |8.5
     Ever confirmed|0                           |1
                 CC|                            |jakub at gcc dot gnu.org
            Summary|internal compiler error in  |[8/9/10/11 Regression]
                   |build_over_call, involving  |internal compiler error in
                   |array new and copy elision  |build_over_call, involving
                   |                            |array new and copy elision
   Last reconfirmed|                            |2021-03-18

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r7-3564-gb7558a2c1f87e374c48fa2be8e3ab93e1b3c68b0

[Bug c++/99643] [8/9/10/11 Regression] internal compiler error in build_over_call, involving array new and copy elision

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
                 CC|                            |jason at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug c++/99643] [8/9/10/11 Regression] internal compiler error in build_over_call, involving array new and copy elision

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:c3d3bb0f03dbd02512ab46979088ee8e22520c24

commit r11-7980-gc3d3bb0f03dbd02512ab46979088ee8e22520c24
Author: Jason Merrill <jason@redhat.com>
Date:   Sat Apr 3 16:17:29 2021 -0400

    c++: array new initialized from a call [PR99643]

    Here the get_foo() call results in a TARGET_EXPR, which we strip in
    massage_init_elt, but then when build_vec_init tries to use it to
initialize
    the array element we crash because build_aggr_init expects a class rvalue
to
    have a TARGET_EXPR.  So don't strip it.

    The stripping was added in r206639 for PR59659, so I checked that removing
    it didn't significantly increase compile time or memory usage for that
    testcase; compile time was unaffected, memory usage increased by 0.00004%.

    gcc/cp/ChangeLog:

            PR c++/99643
            * typeck2.c (massage_init_elt): Don't strip TARGET_EXPR.

    gcc/testsuite/ChangeLog:

            PR c++/99643
            * g++.dg/cpp0x/initlist-new5.C: New test.

[Bug c++/99643] [8/9/10 Regression] internal compiler error in build_over_call, involving array new and copy elision

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9/10/11 Regression]      |[8/9/10 Regression]
                   |internal compiler error in  |internal compiler error in
                   |build_over_call, involving  |build_over_call, involving
                   |array new and copy elision  |array new and copy elision

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for GCC 11 so far.

[Bug c++/99643] [9/10 Regression] internal compiler error in build_over_call, involving array new and copy elision

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

[Bug c++/99643] [9/10 Regression] internal compiler error in build_over_call, involving array new and copy elision

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:dce71e0a274f58fe7cbabba8760f78469ba13548

commit r10-9843-gdce71e0a274f58fe7cbabba8760f78469ba13548
Author: Jason Merrill <jason@redhat.com>
Date:   Sat Apr 3 16:17:29 2021 -0400

    c++: array new initialized from a call [PR99643]

    Here the get_foo() call results in a TARGET_EXPR, which we strip in
    massage_init_elt, but then when build_vec_init tries to use it to
initialize
    the array element we crash because build_aggr_init expects a class rvalue
to
    have a TARGET_EXPR.  So don't strip it.

    The stripping was added in r206639 for PR59659, so I checked that removing
    it didn't significantly increase compile time or memory usage for that
    testcase; compile time was unaffected, memory usage increased by 0.00004%.

    gcc/cp/ChangeLog:

            PR c++/99643
            * typeck2.c (massage_init_elt): Don't strip TARGET_EXPR.

    gcc/testsuite/ChangeLog:

            PR c++/99643
            * g++.dg/cpp0x/initlist-new5.C: New test.

[Bug c++/99643] [9/10 Regression] internal compiler error in build_over_call, involving array new and copy elision

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug c++/99643] [9 Regression] internal compiler error in build_over_call, involving array new and copy elision

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:4231a43fd4ac6ccffd4d4b7cca70d45b2368cede

commit r9-10176-g4231a43fd4ac6ccffd4d4b7cca70d45b2368cede
Author: Jason Merrill <jason@redhat.com>
Date:   Sat Apr 3 16:17:29 2021 -0400

    c++: array new initialized from a call [PR99643]

    Here the get_foo() call results in a TARGET_EXPR, which we strip in
    massage_init_elt, but then when build_vec_init tries to use it to
initialize
    the array element we crash because build_aggr_init expects a class rvalue
to
    have a TARGET_EXPR.  So don't strip it.

    The stripping was added in r206639 for PR59659, so I checked that removing
    it didn't significantly increase compile time or memory usage for that
    testcase; compile time was unaffected, memory usage increased by 0.00004%.

    gcc/cp/ChangeLog:

            PR c++/99643
            * typeck2.c (massage_init_elt): Don't strip TARGET_EXPR.

    gcc/testsuite/ChangeLog:

            PR c++/99643
            * g++.dg/cpp0x/initlist-new5.C: New test.

[Bug c++/99643] [9 Regression] internal compiler error in build_over_call, involving array new and copy elision

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99643

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for 9.5/10.4/11.