[Bug target/99663] New: [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[Bug target/99663] New: [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

            Bug ID: 99663
           Summary: [11 Regression] ICE in extract_constrain_insn, at
                    recog.c:2670 on s390x-linux-gnu
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at debian dot org
  Target Milestone: ---

trunk 20210319 ftbfs on s390x-linux-gnu, with

../../../src/libgcc/../libdecnumber/decNumber.c: In function
‘decQuantizeOp.constprop.isra’:
../../../src/libgcc/../libdecnumber/decNumber.c:5966:3: error: insn does not
satisfy its constraints:
 5966 |   } /* decQuantizeOp */
      |   ^
(insn 252 250 253 26 (set (reg:DI 2 %r2)
        (plus:DI (reg/v/f:DI 24 %f8 [orig:101 res ] [101])
            (const_int 10 [0xa]))) 1471 {*la_64}
     (nil))
during RTL pass: postreload
../../../src/libgcc/../libdecnumber/decNumber.c:5966:3: internal compiler
error: in extract_constrain_insn, at recog.c:2670
0x218b329 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        ../../src/gcc/rtl-error.c:108
0x218b4b5 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        ../../src/gcc/rtl-error.c:118
0x20d66a1 extract_constrain_insn(rtx_insn*)
        ../../src/gcc/recog.c:2670
0x2047e77 reload_cse_simplify_operands
        ../../src/gcc/postreload.c:407
0x2045e61 reload_cse_simplify
        ../../src/gcc/postreload.c:132
0x2046ff1 reload_cse_regs_1
        ../../src/gcc/postreload.c:238
0x204555b reload_cse_regs
        ../../src/gcc/postreload.c:66
0x2056935 execute
        ../../src/gcc/postreload.c:2358
Please submit a full bug report,
with preprocessed source if appropriate.

make[5]: *** [Makefile:646: decNumber.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: Leaving directory '/<<PKGBUILDDIR>>/build/s390x-linux-gnu/libgcc'
make[4]: *** [Makefile:20021: all-stage1-target-libgcc] Error 2
make[4]: Leaving directory '/<<PKGBUILDDIR>>/build'
make[3]: *** [Makefile:27139: stage1-bubble] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/build'
make[2]: *** [Makefile:28089: profiledbootstrap-lean] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/build'

gcc configured with

         --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++
         --with-gcc-major-version-only
         --enable-shared
         --enable-linker-build-id
         --without-included-gettext
         --enable-threads=posix
         --enable-nls
         --enable-bootstrap
         --enable-clocale=gnu
         --enable-libstdcxx-debug
         --enable-libstdcxx-time=yes
         --with-default-libstdcxx-abi=new
         --enable-gnu-unique-object
         --disable-libquadmath
         --disable-libquadmath-support
         --enable-plugin
         --enable-default-pie
         --with-system-zlib
         --enable-libphobos-checking=release
         --with-target-system-zlib=auto
         --enable-objc-gc=auto
         --enable-multiarch
         --disable-werror
         --with-arch=z13
         --with-tune=z15
         --enable-s390-excess-float-precision
         --with-long-double-128
         --enable-multilib
         --enable-checking=yes,extra,rtl
         --build=s390x-linux-gnu
         --host=s390x-linux-gnu
         --target=s390x-linux-gnu
         --with-build-config=bootstrap-lto-lean
         --enable-link-serialization=2

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #1 from Matthias Klose <doko at debian dot org> ---
also seen with          --with-arch=z196

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Can you please attach preprocessed source for it, so that it can be bisected
easily?

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |11.0

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-03-19
             Status|UNCONFIRMED                 |WAITING
                 CC|                            |marxin at gcc dot gnu.org

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #3 from Matthias Klose <doko at debian dot org> ---
trying to reproduce, it ICEs at a different place...

$ cat decNumber.i
typedef struct {
  int exponent;
  unsigned short lsu[];
} decNumber;
char __decd2utable[] = {};
decNumber *decExpOp_rhs;
void decExpOp() {
  decNumber buft[0];
  decNumber allocbuft;
  decNumber *t = buft;
  int t_0;
  if (decExpOp_rhs)
    t = &allocbuft;
  for (;;) {
    unsigned short varbuff[0];
    unsigned short *msu1, *source = t->lsu + (9 ? __decd2utable[t_0] : 3);
    for (; source >= t->lsu; source--, msu1--)
      *msu1 = *source;
    for (; msu1 >= varbuff;)
      ;
    if (t->exponent)
      break;
  }
}

$ build/gcc/xgcc -Bbuild/gcc/ -c -mtune=z15 -march=z13 -mzarch -O1 decNumber.i 
during RTL pass: reload
decNumber.i: In function ‘decExpOp’:
decNumber.i:24:1: internal compiler error: in lra_set_insn_recog_data, at
lra.c:1004
   24 | }
      | ^
0x1ea6333 lra_set_insn_recog_data(rtx_insn*)
        ../../src/gcc/lra.c:1004
0x1ea2063 lra_get_insn_recog_data
        ../../src/gcc/lra-int.h:487
0x1ea9f99 lra_update_insn_regno_info(rtx_insn*)
        ../../src/gcc/lra.c:1625
0x1eab8b7 lra_push_insn_1
        ../../src/gcc/lra.c:1780
0x1eab905 lra_push_insn(rtx_insn*)
        ../../src/gcc/lra.c:1788
0x1eabad9 push_insns
        ../../src/gcc/lra.c:1831
0x1eabd81 lra_process_new_insns(rtx_insn*, rtx_insn*, rtx_insn*, char const*)
        ../../src/gcc/lra.c:1871
0x1ed2bab curr_insn_transform
        ../../src/gcc/lra-constraints.c:4669
0x1ed5c17 lra_constraints(bool)
        ../../src/gcc/lra-constraints.c:5163
0x1eaddb3 lra(_IO_FILE*)
        ../../src/gcc/lra.c:2336
0x1e13ec3 do_reload
        ../../src/gcc/ira.c:5834
0x1e145f1 execute
        ../../src/gcc/ira.c:6020
Please submit a full bug report,
with preprocessed source if appropriate.

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #4 from Matthias Klose <doko at debian dot org> ---
Created attachment 50433
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50433&action=edit
preprocessed source

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #5 from Matthias Klose <doko at debian dot org> ---
and the reduction for the original ICE:

typedef struct {
  int exponent;
  unsigned short lsu[];
} decNumber;
decNumber decDivideOp_lhs;
short decDivideOp_varbuff;
void decDivideOp(decNumber *rhs) {
  short *msu1;
  int exponent;
  unsigned short *source;
  for (; source >= decDivideOp_lhs.lsu; source--, msu1--)
    *msu1 = *source;
  for (;;)
    if (exponent)
      if (decDivideOp_varbuff)
        exponent = rhs->exponent;
}

$ build/gcc/xgcc -Bbuild/gcc/ -c -mtune=z15 -march=z13 -mzarch -O2
-fno-stack-protector -fPIC decNumber.i 
decNumber.i: In function ‘decDivideOp’:
decNumber.i:17:1: error: insn does not satisfy its constraints:
   17 | }
      | ^
(insn 7 6 2 2 (set (reg:DI 3 %r3 [69])
        (plus:DI (reg:DI 0 %r0 [77])
            (const_int 4 [0x4]))) "decNumber.i":11:17 1471 {*la_64}
     (nil))
during RTL pass: reload
decNumber.i:17:1: internal compiler error: in extract_constrain_insn, at
recog.c:2670
0x218b329 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        ../../src/gcc/rtl-error.c:108
0x218b4b5 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        ../../src/gcc/rtl-error.c:118
0x20d66a1 extract_constrain_insn(rtx_insn*)
        ../../src/gcc/recog.c:2670
0x1ead125 check_rtl
        ../../src/gcc/lra.c:2087
0x1eae299 lra(_IO_FILE*)
        ../../src/gcc/lra.c:2505
0x1e13ec3 do_reload
        ../../src/gcc/ira.c:5834
0x1e145f1 execute
        ../../src/gcc/ira.c:6020
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

Matthias Klose <doko at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
                 CC|                            |doko at gcc dot gnu.org

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Can't reproduce #c3 but can reproduce #c5, bisecting.

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

Matthias Klose <doko at debian dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at gcc dot gnu.org

--- Comment #7 from Matthias Klose <doko at debian dot org> ---
introduced by a4670f58ebff805e35268542aac35f9791980954

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Indeed, r11-7725-ga4670f58ebff805e35268542aac35f9791980954 (please, at least
prefix git hashes with g: so that one gets link).

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #9 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Thank you for reporting this.  I've reproduced this crash.  ETA of the patch is
Monday at worst.

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Vladimir Makarov <vmakarov@gcc.gnu.org>:

https://gcc.gnu.org/g:d81019db099ad95febbb2d4b4afd8cbe95762062

commit r11-7741-gd81019db099ad95febbb2d4b4afd8cbe95762062
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Fri Mar 19 15:34:48 2021 -0400

    [PR99663] Don't use unknown constraint for address constraint in
process_address_1.

    s390x has insns using several alternatives with address constraints.  Even
    if we don't know at this stage what alternative will be used, we still can
say
    that is an address constraint.  So don't use unknown constraint in this
    case when there are multiple constraints or/and alternative.

    gcc/ChangeLog:

            PR target/99663
            * lra-constraints.c (process_address_1): Don't use unknown
            constraint for address constraint.

    gcc/testsuite/ChangeLog:

            PR target/99663
            * gcc.target/s390/pr99663.c: New.

[Bug target/99663] [11 Regression] ICE in extract_constrain_insn, at recog.c:2670 on s390x-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99663

Matthias Klose <doko at debian dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #11 from Matthias Klose <doko at debian dot org> ---
fixed