[Bug fortran/99819] New: [9/10/11 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[Bug fortran/99819] New: [9/10/11 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

            Bug ID: 99819
           Summary: [9/10/11 Regression] ICE in gfc_defer_symbol_init, at
                    fortran/trans-decl.c:841
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r6 :


$ cat z1.f90
program p
   type t
   end type
contains
   function f(x, y)
      class(t) :: x(:)
      class(*) :: y(size(x))
   end
   function g(z)
      class(*) :: z(:)
      type(t) :: u(size(z))
   end
end


$ gfortran-5 -c z1.f90
$
$ gfortran-11-20210328 -c z1.f90
z1.f90:9:15:

    9 |    function g(z)
      |               1
internal compiler error: Segmentation fault
0xc09d4f crash_signal
        ../../gcc/toplev.c:327
0x75328b gfc_defer_symbol_init
        ../../gcc/fortran/trans-decl.c:841
0x756e5f gfc_defer_symbol_init
        ../../gcc/fortran/trans-decl.c:1229
0x756e5f gfc_build_dummy_array_decl
        ../../gcc/fortran/trans-decl.c:1209
0x75b443 gfc_get_symbol_decl(gfc_symbol*)
        ../../gcc/fortran/trans-decl.c:1697
0x76ac18 gfc_conv_variable
        ../../gcc/fortran/trans-expr.c:2913
0x766dda gfc_conv_expr(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-expr.c:8938
0x769c40 gfc_conv_expr_lhs(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-expr.c:8968
0x73cea8 gfc_conv_ss_descriptor
        ../../gcc/fortran/trans-array.c:3050
0x7473ac gfc_conv_expr_descriptor(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-array.c:7367
0x77a102 gfc_conv_intrinsic_size
        ../../gcc/fortran/trans-intrinsic.c:8063
0x79186b gfc_conv_intrinsic_function(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-intrinsic.c:10702
0x766dba gfc_conv_expr(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-expr.c:8930
0x769c83 gfc_conv_expr_val(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-expr.c:8983
0x769dd0 gfc_conv_expr_type(gfc_se*, gfc_expr*, tree_node*)
        ../../gcc/fortran/trans-expr.c:8997
0x742bbf gfc_trans_dummy_array_bias(gfc_symbol*, tree_node*,
gfc_wrapped_block*)
        ../../gcc/fortran/trans-array.c:6770
0x75d0dc gfc_trans_deferred_vars(gfc_symbol*, gfc_wrapped_block*)
        ../../gcc/fortran/trans-decl.c:4905
0x75f6d2 gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.c:6988
0x75f3e4 gfc_generate_contained_functions
        ../../gcc/fortran/trans-decl.c:5878
0x75f3e4 gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.c:6816

[Bug fortran/99819] [9/10/11 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |9.4

[Bug fortran/99819] [9/10/11 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-03-30
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.  I believe there are tons of duplicates of this one.

[Bug fortran/99819] [9/10/11/12 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |pault at gcc dot gnu.org

--- Comment #2 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 50735
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50735&action=edit
Experimenta "fix" for the PR

The problem lies in class.c(gfc_build_class_symbol).

The attachment contains two different experiments to test the hypothesis that
the array_spec for 'y' is applied to the _data field of the derived type, which
is then promoted to the main namespace. Subsequently, it is picked up in the
declaration of 'z', which cause the problem.

The first chunk, used by itself, turns the array_spec into a deferred array.
The extent information is lost but the testcase now compiles and runs
(incorrectly!). The second chunk, again by itself, puts the derived type
representation in the function namespace. This now runs the testcase correctly
and does the right thing. However, it can only encompass one such dummy.

I'm onto it:-)

Paul

program p
   type t
      integer :: i
   end type
   class(t), allocatable :: dum1(:), dum2(:)
   allocate (t :: dum1(3), dum2(10))
   dum2%i = [1,2,3,4,5,6,7,8,9,10]
   print *, f(dum1, dum2), g(dum1)
contains
   function g(z)
      class(*) :: z(:)
      type(t) :: u(size(z))
      g = 0
   end
   function f(x, y)
      class(t) :: x(:)
      class(*) :: y(size(x))
      print *, size(y)
      select type (y)
        type is (t)
          f = 1
          if (any (y%i .ne. [1,2,3])) print *, size(y%i)
        class default
          f = 0
      end select
   end
end

[Bug fortran/99819] [9/10/11/12 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug fortran/99819] [9/10/11/12 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:a2c593009fef1564dbef2237ee71e9fd08f5361e

commit r12-570-ga2c593009fef1564dbef2237ee71e9fd08f5361e
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Thu May 6 14:41:33 2021 +0100

    Fortran: Assumed and explicit size class arrays [PR46691/99819].

    2021-05-06  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * class.c (gfc_build_class_symbol): Remove the error that
            disables assumed size class arrays. Class array types that are
            not deferred shape or assumed rank are given a unique name and
            placed in the procedure namespace.
            * trans-array.c (gfc_trans_g77_array): Obtain the data pointer
            for class arrays.
            (gfc_trans_dummy_array_bias): Suppress the runtime error for
            extent violations in explicit shape class arrays because it
            always fails.
            * trans-expr.c (gfc_conv_procedure_call): Handle assumed size
            class actual arguments passed to non-descriptor formal args by
            using the data pointer, stored as the symbol's backend decl.

    gcc/testsuite/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * gfortran.dg/class_dummy_6.f90: New test.
            * gfortran.dg/class_dummy_7.f90: New test.

[Bug fortran/99819] [9/10/11/12 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug fortran/99819] [9/10/11/12 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #5 from anlauf at gcc dot gnu.org ---
Paul, are you planning to backport?

This one would also (supposedly) fix pr92065.

[Bug fortran/99819] [9/10/11/12 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:be64e725111fdb9caa05374823b4423b8ab49dc7

commit r11-8936-gbe64e725111fdb9caa05374823b4423b8ab49dc7
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Thu May 6 14:41:33 2021 +0100

    Fortran: Assumed and explicit size class arrays [PR46691/99819].

    2021-05-06  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * class.c (gfc_build_class_symbol): Remove the error that
            disables assumed size class arrays. Class array types that are
            not deferred shape or assumed rank are given a unique name and
            placed in the procedure namespace.
            * trans-array.c (gfc_trans_g77_array): Obtain the data pointer
            for class arrays.
            (gfc_trans_dummy_array_bias): Suppress the runtime error for
            extent violations in explicit shape class arrays because it
            always fails.
            * trans-expr.c (gfc_conv_procedure_call): Handle assumed size
            class actual arguments passed to non-descriptor formal args by
            using the data pointer, stored as the symbol's backend decl.

    gcc/testsuite/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * gfortran.dg/class_dummy_6.f90: New test.
            * gfortran.dg/class_dummy_7.f90: New test.

    (cherry picked from commit a2c593009fef1564dbef2237ee71e9fd08f5361e)

[Bug fortran/99819] [9/10 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11/12 Regression] ICE |[9/10 Regression] ICE in
                   |in gfc_defer_symbol_init,   |gfc_defer_symbol_init, at
                   |at fortran/trans-decl.c:841 |fortran/trans-decl.c:841

--- Comment #7 from anlauf at gcc dot gnu.org ---
Cherry-picked to 11-branch (with permit by Paul) after regtesting.

[Bug fortran/99819] [9/10 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:53907e20ee1fdf91163ff19b8f1dc716563e903a

commit r10-10081-g53907e20ee1fdf91163ff19b8f1dc716563e903a
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Thu May 6 14:41:33 2021 +0100

    Fortran: Assumed and explicit size class arrays [PR46691/99819].

    2021-05-06  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * class.c (gfc_build_class_symbol): Remove the error that
            disables assumed size class arrays. Class array types that are
            not deferred shape or assumed rank are given a unique name and
            placed in the procedure namespace.
            * trans-array.c (gfc_trans_g77_array): Obtain the data pointer
            for class arrays.
            (gfc_trans_dummy_array_bias): Suppress the runtime error for
            extent violations in explicit shape class arrays because it
            always fails.
            * trans-expr.c (gfc_conv_procedure_call): Handle assumed size
            class actual arguments passed to non-descriptor formal args by
            using the data pointer, stored as the symbol's backend decl.

    gcc/testsuite/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * gfortran.dg/class_dummy_6.f90: New test.
            * gfortran.dg/class_dummy_7.f90: New test.

    (cherry picked from commit a2c593009fef1564dbef2237ee71e9fd08f5361e)

[Bug fortran/99819] [9 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10 Regression] ICE in    |[9 Regression] ICE in
                   |gfc_defer_symbol_init, at   |gfc_defer_symbol_init, at
                   |fortran/trans-decl.c:841    |fortran/trans-decl.c:841

--- Comment #9 from anlauf at gcc dot gnu.org ---
Cherry-picked to 10-branch after verifying that it regtests fine.

[Bug fortran/99819] [9 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:c8cd1acae4c26929400fae0d7fb17cfef8c15be0

commit r9-9712-gc8cd1acae4c26929400fae0d7fb17cfef8c15be0
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Thu May 6 14:41:33 2021 +0100

    Fortran: Assumed and explicit size class arrays [PR46691/99819].

    2021-05-06  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * class.c (gfc_build_class_symbol): Remove the error that
            disables assumed size class arrays. Class array types that are
            not deferred shape or assumed rank are given a unique name and
            placed in the procedure namespace.
            * trans-array.c (gfc_trans_g77_array): Obtain the data pointer
            for class arrays.
            (gfc_trans_dummy_array_bias): Suppress the runtime error for
            extent violations in explicit shape class arrays because it
            always fails.
            * trans-expr.c (gfc_conv_procedure_call): Handle assumed size
            class actual arguments passed to non-descriptor formal args by
            using the data pointer, stored as the symbol's backend decl.

    gcc/testsuite/ChangeLog

            PR fortran/46691
            PR fortran/99819
            * gfortran.dg/class_dummy_6.f90: New test.
            * gfortran.dg/class_dummy_7.f90: New test.

    (cherry picked from commit a2c593009fef1564dbef2237ee71e9fd08f5361e)

[Bug fortran/99819] [9 Regression] ICE in gfc_defer_symbol_init, at fortran/trans-decl.c:841

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99819

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from anlauf at gcc dot gnu.org ---
Pushed fix by Paul to all open branches.  Closing.

Thanks for the report!