* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
@ 2021-03-30 19:53 ` anlauf at gcc dot gnu.org
2021-03-30 20:05 ` kargl at gcc dot gnu.org
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-03-30 19:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
Last reconfirmed| |2021-03-30
Known to fail| |10.2.1, 11.0, 8.4.1, 9.3.1
Priority|P3 |P4
CC| |anlauf at gcc dot gnu.org
--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.
This one is funny. The TRANSPOSE seems to screw up the simplification.
Works without TRANSPOSE.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
2021-03-30 19:53 ` [Bug fortran/99840] " anlauf at gcc dot gnu.org
@ 2021-03-30 20:05 ` kargl at gcc dot gnu.org
2021-03-31 8:10 ` rguenth at gcc dot gnu.org
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: kargl at gcc dot gnu.org @ 2021-03-30 20:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
kargl at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kargl at gcc dot gnu.org
--- Comment #2 from kargl at gcc dot gnu.org ---
Patch. Check if a or b is zero-sized.
diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index 388aca7c38c..6c5259c648d 100644
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -4728,7 +4728,9 @@ gfc_simplify_matmul (gfc_expr *matrix_a, gfc_expr
*matrix_b)
int stride_a, offset_a, stride_b, offset_b;
if (!is_constant_array_expr (matrix_a)
- || !is_constant_array_expr (matrix_b))
+ || gfc_is_size_zero_array (matrix_a)
+ || !is_constant_array_expr (matrix_b)
+ || gfc_is_size_zero_array (matrix_b))
return NULL;
/* MATMUL should do mixed-mode arithmetic. Set the result type. */
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
2021-03-30 19:53 ` [Bug fortran/99840] " anlauf at gcc dot gnu.org
2021-03-30 20:05 ` kargl at gcc dot gnu.org
@ 2021-03-31 8:10 ` rguenth at gcc dot gnu.org
2021-03-31 12:54 ` marxin at gcc dot gnu.org
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-03-31 8:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |9.4
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (2 preceding siblings ...)
2021-03-31 8:10 ` rguenth at gcc dot gnu.org
@ 2021-03-31 12:54 ` marxin at gcc dot gnu.org
2021-03-31 20:38 ` anlauf at gcc dot gnu.org
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-03-31 12:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r8-4151-g6c6bde30706c29ff.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (3 preceding siblings ...)
2021-03-31 12:54 ` marxin at gcc dot gnu.org
@ 2021-03-31 20:38 ` anlauf at gcc dot gnu.org
2021-03-31 20:51 ` anlauf at gcc dot gnu.org
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-03-31 20:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #4 from anlauf at gcc dot gnu.org ---
For reasons I do not understand,
Breakpoint 1, gfc_simplify_matmul (matrix_a=0x292bbf0, matrix_b=0x292c550)
at ../../gcc-trunk/gcc/fortran/simplify.c:4777
4777 result_columns = mpz_get_si (matrix_b->shape[1]);
(gdb) p matrix_b->shape[1]
$64 = {{_mp_alloc = 0, _mp_size = 0, _mp_d = 0x0}}
(gdb) p matrix_b->shape[0]
$65 = {{_mp_alloc = 0, _mp_size = 0, _mp_d = 0x0}}
This is a result from the mpz_set in gfc_simplify_transpose.
Isn't this a representation of zero?
Alternative patch, which passes the relevant regtesting:
diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index 388aca7c38c..b884a81fce0 100644
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -8123,16 +8123,16 @@ gfc_simplify_transpose (gfc_expr *matrix)
&matrix->where);
result->rank = 2;
result->shape = gfc_get_shape (result->rank);
- mpz_set (result->shape[0], matrix->shape[1]);
- mpz_set (result->shape[1], matrix->shape[0]);
+ matrix_rows = mpz_get_si (matrix->shape[0]);
+ matrix_cols = mpz_get_si (matrix->shape[1]);
+ mpz_init_set_si (result->shape[0], matrix_cols);
+ mpz_init_set_si (result->shape[1], matrix_rows);
if (matrix->ts.type == BT_CHARACTER)
result->ts.u.cl = matrix->ts.u.cl;
else if (matrix->ts.type == BT_DERIVED)
result->ts.u.derived = matrix->ts.u.derived;
- matrix_rows = mpz_get_si (matrix->shape[0]);
- matrix_cols = mpz_get_si (matrix->shape[1]);
for (row = 0; row < matrix_rows; ++row)
for (col = 0; col < matrix_cols; ++col)
{
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (4 preceding siblings ...)
2021-03-31 20:38 ` anlauf at gcc dot gnu.org
@ 2021-03-31 20:51 ` anlauf at gcc dot gnu.org
2021-03-31 21:07 ` sgk at troutmask dot apl.washington.edu
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-03-31 20:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #5 from anlauf at gcc dot gnu.org ---
OK, now I see it. gfc_get_shape does not init the resulting shape.
The following simpler patch does the job:
diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index 388aca7c38c..c27b47aa98f 100644
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -8123,8 +8123,8 @@ gfc_simplify_transpose (gfc_expr *matrix)
&matrix->where);
result->rank = 2;
result->shape = gfc_get_shape (result->rank);
- mpz_set (result->shape[0], matrix->shape[1]);
- mpz_set (result->shape[1], matrix->shape[0]);
+ mpz_init_set (result->shape[0], matrix->shape[1]);
+ mpz_init_set (result->shape[1], matrix->shape[0]);
if (matrix->ts.type == BT_CHARACTER)
result->ts.u.cl = matrix->ts.u.cl;
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (5 preceding siblings ...)
2021-03-31 20:51 ` anlauf at gcc dot gnu.org
@ 2021-03-31 21:07 ` sgk at troutmask dot apl.washington.edu
2021-03-31 21:11 ` anlauf at gmx dot de
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: sgk at troutmask dot apl.washington.edu @ 2021-03-31 21:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #6 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Wed, Mar 31, 2021 at 08:51:57PM +0000, anlauf at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
>
> --- Comment #5 from anlauf at gcc dot gnu.org ---
> OK, now I see it. gfc_get_shape does not init the resulting shape.
> The following simpler patch does the job:
>
> diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
> index 388aca7c38c..c27b47aa98f 100644
> --- a/gcc/fortran/simplify.c
> +++ b/gcc/fortran/simplify.c
> @@ -8123,8 +8123,8 @@ gfc_simplify_transpose (gfc_expr *matrix)
> &matrix->where);
> result->rank = 2;
> result->shape = gfc_get_shape (result->rank);
> - mpz_set (result->shape[0], matrix->shape[1]);
> - mpz_set (result->shape[1], matrix->shape[0]);
> + mpz_init_set (result->shape[0], matrix->shape[1]);
> + mpz_init_set (result->shape[1], matrix->shape[0]);
>
> if (matrix->ts.type == BT_CHARACTER)
> result->ts.u.cl = matrix->ts.u.cl;
>
The simple patch in comment #2 also works.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (6 preceding siblings ...)
2021-03-31 21:07 ` sgk at troutmask dot apl.washington.edu
@ 2021-03-31 21:11 ` anlauf at gmx dot de
2021-03-31 21:12 ` anlauf at gcc dot gnu.org
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: anlauf at gmx dot de @ 2021-03-31 21:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #7 from Harald Anlauf <anlauf at gmx dot de> ---
> The simple patch in comment #2 also works.
I know. But it only covers the issue in gfc_simplify_transpose.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (7 preceding siblings ...)
2021-03-31 21:11 ` anlauf at gmx dot de
@ 2021-03-31 21:12 ` anlauf at gcc dot gnu.org
2021-04-01 5:50 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-03-31 21:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #8 from anlauf at gcc dot gnu.org ---
Patch: https://gcc.gnu.org/pipermail/fortran/2021-March/055897.html
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (8 preceding siblings ...)
2021-03-31 21:12 ` anlauf at gcc dot gnu.org
@ 2021-04-01 5:50 ` cvs-commit at gcc dot gnu.org
2021-04-01 6:15 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-01 5:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:d7cef070bf43bfb3f3d77bac42eadea06c4b0281
commit r11-7943-gd7cef070bf43bfb3f3d77bac42eadea06c4b0281
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Apr 1 07:49:32 2021 +0200
PR fortran/99840 - ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
The simplification of the transposition of a constant array shall properly
initialize and set the shape of the result.
gcc/fortran/ChangeLog:
PR fortran/99840
* simplify.c (gfc_simplify_transpose): Properly initialize
resulting shape.
gcc/testsuite/ChangeLog:
PR fortran/99840
* gfortran.dg/transpose_5.f90: New test.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (9 preceding siblings ...)
2021-04-01 5:50 ` cvs-commit at gcc dot gnu.org
@ 2021-04-01 6:15 ` cvs-commit at gcc dot gnu.org
2021-04-02 18:54 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-01 6:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:591b5c903f8d3fc73caa403038cbd680b367f23b
commit r10-9648-g591b5c903f8d3fc73caa403038cbd680b367f23b
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Apr 1 07:49:32 2021 +0200
PR fortran/99840 - ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
The simplification of the transposition of a constant array shall properly
initialize and set the shape of the result.
gcc/fortran/ChangeLog:
PR fortran/99840
* simplify.c (gfc_simplify_transpose): Properly initialize
resulting shape.
gcc/testsuite/ChangeLog:
PR fortran/99840
* gfortran.dg/transpose_5.f90: New test.
(cherry picked from commit d7cef070bf43bfb3f3d77bac42eadea06c4b0281)
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (10 preceding siblings ...)
2021-04-01 6:15 ` cvs-commit at gcc dot gnu.org
@ 2021-04-02 18:54 ` cvs-commit at gcc dot gnu.org
2021-04-02 19:02 ` cvs-commit at gcc dot gnu.org
2021-04-02 19:03 ` anlauf at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-02 18:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:0c7d11dbd216df4c1ae2f47138321b399e7349f0
commit r9-9319-g0c7d11dbd216df4c1ae2f47138321b399e7349f0
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Apr 1 07:49:32 2021 +0200
PR fortran/99840 - ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
The simplification of the transposition of a constant array shall properly
initialize and set the shape of the result.
gcc/fortran/ChangeLog:
PR fortran/99840
* simplify.c (gfc_simplify_transpose): Properly initialize
resulting shape.
gcc/testsuite/ChangeLog:
PR fortran/99840
* gfortran.dg/transpose_5.f90: New test.
(cherry picked from commit d7cef070bf43bfb3f3d77bac42eadea06c4b0281)
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (11 preceding siblings ...)
2021-04-02 18:54 ` cvs-commit at gcc dot gnu.org
@ 2021-04-02 19:02 ` cvs-commit at gcc dot gnu.org
2021-04-02 19:03 ` anlauf at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-02 19:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:28ba017a7ef5d0d0ebe4a37e52db22f667c1c0e2
commit r8-10828-g28ba017a7ef5d0d0ebe4a37e52db22f667c1c0e2
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Apr 1 07:49:32 2021 +0200
PR fortran/99840 - ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
The simplification of the transposition of a constant array shall properly
initialize and set the shape of the result.
gcc/fortran/ChangeLog:
PR fortran/99840
* simplify.c (gfc_simplify_transpose): Properly initialize
resulting shape.
gcc/testsuite/ChangeLog:
PR fortran/99840
* gfortran.dg/transpose_5.f90: New test.
(cherry picked from commit d7cef070bf43bfb3f3d77bac42eadea06c4b0281)
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/99840] [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777
2021-03-30 19:13 [Bug fortran/99840] New: [9/10/11 Regression] ICE in gfc_simplify_matmul, at fortran/simplify.c:4777 gscfq@t-online.de
` (12 preceding siblings ...)
2021-04-02 19:02 ` cvs-commit at gcc dot gnu.org
@ 2021-04-02 19:03 ` anlauf at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-04-02 19:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99840
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #13 from anlauf at gcc dot gnu.org ---
Fixed on mainline and all open branches. Closing.
Thanks for the report!
^ permalink raw reply [flat|nested] 15+ messages in thread