[Bug fortran/99884] New: Double spaces in warning message

[Bug fortran/99884] New: Double spaces in warning message

[goeran at uddeborg dot se]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99884

            Bug ID: 99884
           Summary: Double spaces in warning message
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: goeran at uddeborg dot se
  Target Milestone: ---

At
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/fortran/io.c;h=40cd76eb5858614c81de98b59a4f6e5b814988ea;hb=HEAD#l2494
the variable "spec" is either set to a string followed by a space, or an empty
string. This seems like a good way to be able to create a correct error message
when there is a valid string to print but avoid an extra space when not. But
when actually used in a message a few lines below, this feature is not taken
advantage of, and the specifier is followed by a space regardless. That will
make two spaces if there is a valid string, and one useless space when "spec"
is empty.

Unless I miss something the message string should begin "%sspecifier at %L not 
…"

[Bug fortran/99884] Double spaces in warning message

[aldot at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99884

Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-10-31
                 CC|                            |aldot at gcc dot gnu.org
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2021-October
                   |                            |/582974.html
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> ---
Confirmed.

[Bug fortran/99884] Double spaces in warning message

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99884

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Bernhard Reutner-Fischer
<aldot@gcc.gnu.org>:

https://gcc.gnu.org/g:19be89d79ee149e812ccc6027956cefb7f3e1016

commit r13-4133-g19be89d79ee149e812ccc6027956cefb7f3e1016
Author: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
Date:   Sun Oct 31 13:57:46 2021 +0100

    Fortran: Remove double spaces in open() warning [PR99884]

    gcc/fortran/ChangeLog:

            PR fortran/99884
            * io.cc (check_open_constraints): Remove double spaces.