public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r10-9843] c++: array new initialized from a call [PR99643]
@ 2021-05-20 21:34 Jason Merrill
0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2021-05-20 21:34 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:dce71e0a274f58fe7cbabba8760f78469ba13548
commit r10-9843-gdce71e0a274f58fe7cbabba8760f78469ba13548
Author: Jason Merrill <jason@redhat.com>
Date: Sat Apr 3 16:17:29 2021 -0400
c++: array new initialized from a call [PR99643]
Here the get_foo() call results in a TARGET_EXPR, which we strip in
massage_init_elt, but then when build_vec_init tries to use it to initialize
the array element we crash because build_aggr_init expects a class rvalue to
have a TARGET_EXPR. So don't strip it.
The stripping was added in r206639 for PR59659, so I checked that removing
it didn't significantly increase compile time or memory usage for that
testcase; compile time was unaffected, memory usage increased by 0.00004%.
gcc/cp/ChangeLog:
PR c++/99643
* typeck2.c (massage_init_elt): Don't strip TARGET_EXPR.
gcc/testsuite/ChangeLog:
PR c++/99643
* g++.dg/cpp0x/initlist-new5.C: New test.
Diff:
---
gcc/cp/typeck2.c | 3 ---
gcc/testsuite/g++.dg/cpp0x/initlist-new5.C | 9 +++++++++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gcc/cp/typeck2.c b/gcc/cp/typeck2.c
index 96421caf22e..81caed45757 100644
--- a/gcc/cp/typeck2.c
+++ b/gcc/cp/typeck2.c
@@ -1442,9 +1442,6 @@ massage_init_elt (tree type, tree init, int nested, int flags,
if (flags & LOOKUP_AGGREGATE_PAREN_INIT)
new_flags |= LOOKUP_AGGREGATE_PAREN_INIT;
init = digest_init_r (type, init, nested ? 2 : 1, new_flags, complain);
- /* Strip a simple TARGET_EXPR when we know this is an initializer. */
- if (SIMPLE_TARGET_EXPR_P (init))
- init = TARGET_EXPR_INITIAL (init);
/* When we defer constant folding within a statement, we may want to
defer this folding as well. */
tree t = fold_non_dependent_init (init, complain);
diff --git a/gcc/testsuite/g++.dg/cpp0x/initlist-new5.C b/gcc/testsuite/g++.dg/cpp0x/initlist-new5.C
new file mode 100644
index 00000000000..da54d8981d4
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/initlist-new5.C
@@ -0,0 +1,9 @@
+// PR c++/99643
+// { dg-do compile { target c++11 } }
+
+struct Foo {};
+Foo get_foo();
+
+int main() {
+ new Foo[1]{get_foo()};
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-20 21:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 21:34 [gcc r10-9843] c++: array new initialized from a call [PR99643] Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).