public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-1112] c/100803 - diagnose invalid GIMPLE condition
@ 2021-05-28 12:25 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2021-05-28 12:25 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:8b2b32ab2d8cff4eb0dad0ef4e72e33257574cb6
commit r12-1112-g8b2b32ab2d8cff4eb0dad0ef4e72e33257574cb6
Author: Richard Biener <rguenther@suse.de>
Date: Fri May 28 13:05:39 2021 +0200
c/100803 - diagnose invalid GIMPLE condition
another easy fix for GIMPLE FE parser robustness.
2021-05-28 Richard Biener <rguenther@suse.de>
PR c/100803
gcc/c/
* gimple-parser.c (c_parser_gimple_paren_condition): Diagnose
invalid if conditions.
gcc/testsuite/
* gcc.dg/gimplefe-error-11.c: New testcase.
Diff:
---
gcc/c/gimple-parser.c | 8 ++++++++
gcc/testsuite/gcc.dg/gimplefe-error-11.c | 12 ++++++++++++
2 files changed, 20 insertions(+)
diff --git a/gcc/c/gimple-parser.c b/gcc/c/gimple-parser.c
index dfacf23c40a..c8d9db61f0a 100644
--- a/gcc/c/gimple-parser.c
+++ b/gcc/c/gimple-parser.c
@@ -2112,6 +2112,14 @@ c_parser_gimple_paren_condition (gimple_parser &parser)
if (! c_parser_require (parser, CPP_OPEN_PAREN, "expected %<(%>"))
return error_mark_node;
tree cond = c_parser_gimple_binary_expression (parser).value;
+ if (cond != error_mark_node
+ && ! COMPARISON_CLASS_P (cond)
+ && ! CONSTANT_CLASS_P (cond)
+ && ! SSA_VAR_P (cond))
+ {
+ c_parser_error (parser, "comparison required");
+ cond = error_mark_node;
+ }
if (! c_parser_require (parser, CPP_CLOSE_PAREN, "expected %<)%>"))
return error_mark_node;
return cond;
diff --git a/gcc/testsuite/gcc.dg/gimplefe-error-11.c b/gcc/testsuite/gcc.dg/gimplefe-error-11.c
new file mode 100644
index 00000000000..9c29717676a
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/gimplefe-error-11.c
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+/* { dg-options "-fgimple" } */
+
+int bar();
+__GIMPLE
+int foo()
+{
+ if (bar()) /* { dg-error "comparison required" } */
+ goto bb1;
+ else
+ goto bb2;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-28 12:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 12:25 [gcc r12-1112] c/100803 - diagnose invalid GIMPLE condition Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).