public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/omp/gcc-11] openmp: Add testcase for scan directive with nested functions
@ 2021-06-08 6:22 Tobias Burnus
0 siblings, 0 replies; only message in thread
From: Tobias Burnus @ 2021-06-08 6:22 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:e3433dd498e240ea4d642fb99594250eb78fd5fb
commit e3433dd498e240ea4d642fb99594250eb78fd5fb
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Jun 8 08:22:02 2021 +0200
openmp: Add testcase for scan directive with nested functions
> In convert_nonlocal_omp_clauses, the following clauses are
> missing: OMP_CLAUSE_AFFINITY, OMP_CLAUSE_DEVICE_TYPE,
> OMP_CLAUSE_EXCLUSIVE, OMP_CLAUSE_INCLUSIVE.
OMP_CLAUSE_{EXCLUSIVE,INCLUSIVE} isn't needed, because we don't
walk the clauses at all for GIMPLE_OMP_SCAN. It would be a bug
if we used the exclusive/inclusive operands after gimplification,
but we apparently don't do that, all we check is whether the
OMP_CLAUSE_KIND of the first clause (all should be the same) is
OMP_CLAUSE_EXCLUSIVE or OMP_CLAUSE_INCLUSIVE, nothing else.
That said, I think we should have a testcase.
2021-06-06 Jakub Jelinek <jakub@redhat.com>
* gcc.dg/gomp/scan-1.c: New test.
(cherry picked from commit cb4b99be48af1c0911ce2a957af20d9cd946f364)
Diff:
---
gcc/testsuite/ChangeLog.omp | 7 ++++++
gcc/testsuite/gcc.dg/gomp/scan-1.c | 51 ++++++++++++++++++++++++++++++++++++++
2 files changed, 58 insertions(+)
diff --git a/gcc/testsuite/ChangeLog.omp b/gcc/testsuite/ChangeLog.omp
index 4ed55d768af..b7bf03ab9cb 100644
--- a/gcc/testsuite/ChangeLog.omp
+++ b/gcc/testsuite/ChangeLog.omp
@@ -1,3 +1,10 @@
+2021-06-08 Tobias Burnus <tobias@codesourcery.com>
+
+ Backported from master:
+ 2021-06-06 Jakub Jelinek <jakub@redhat.com>
+
+ * gcc.dg/gomp/scan-1.c: New test.
+
2021-06-04 Tobias Burnus <tobias@codesourcery.com>
Backported from master:
diff --git a/gcc/testsuite/gcc.dg/gomp/scan-1.c b/gcc/testsuite/gcc.dg/gomp/scan-1.c
new file mode 100644
index 00000000000..807071d9156
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/gomp/scan-1.c
@@ -0,0 +1,51 @@
+int baz (void);
+void qux (int);
+int r;
+
+int
+foo (void)
+{
+ int r = 0, i;
+ void bar (void) { r++; }
+ #pragma omp parallel for reduction(inscan, +:r)
+ for (i = 0; i < 64; i++)
+ {
+ r += baz ();
+ #pragma omp scan inclusive(r)
+ qux (r);
+ }
+ #pragma omp parallel for reduction(inscan, +:r)
+ for (i = 0; i < 64; i++)
+ {
+ qux (r);
+ #pragma omp scan exclusive(r)
+ r += baz ();
+ }
+ bar ();
+ return r;
+}
+
+int
+corge (void)
+{
+ int r = 0, i;
+ void bar (void)
+ {
+ #pragma omp parallel for reduction(inscan, +:r)
+ for (i = 0; i < 64; i++)
+ {
+ r += baz ();
+ #pragma omp scan inclusive(r)
+ qux (r);
+ }
+ #pragma omp parallel for reduction(inscan, +:r)
+ for (i = 0; i < 64; i++)
+ {
+ qux (r);
+ #pragma omp scan exclusive(r)
+ r += baz ();
+ }
+ }
+ bar ();
+ return r;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-08 6:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 6:22 [gcc/devel/omp/gcc-11] openmp: Add testcase for scan directive with nested functions Tobias Burnus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).