public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-8656] Fix SLP permute propagation error
@ 2021-06-25 9:06 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2021-06-25 9:06 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:62bbb113ae68a7e724255e17143520735bcb9ec9
commit r11-8656-g62bbb113ae68a7e724255e17143520735bcb9ec9
Author: Richard Biener <rguenther@suse.de>
Date: Thu Jun 24 10:47:18 2021 +0200
Fix SLP permute propagation error
This fixes SLP permute propagation to not propagate across operations
that have different semantics on different lanes like for example
the recently added COMPLEX_ADD_ROT90.
2021-06-24 Richard Biener <rguenther@suse.de>
* tree-vect-slp.c (vect_optimize_slp): Do not propagate
across operations that have different semantics on different
lanes.
Diff:
---
gcc/tree-vect-slp.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/gcc/tree-vect-slp.c b/gcc/tree-vect-slp.c
index 8ee2c231672..a40b2f06a5f 100644
--- a/gcc/tree-vect-slp.c
+++ b/gcc/tree-vect-slp.c
@@ -3180,11 +3180,25 @@ vect_optimize_slp (vec_info *vinfo)
bitmap_set_bit (n_visited, idx);
- /* We cannot move a permute across a store. */
- if (STMT_VINFO_DATA_REF (SLP_TREE_REPRESENTATIVE (node))
- && DR_IS_WRITE
- (STMT_VINFO_DATA_REF (SLP_TREE_REPRESENTATIVE (node))))
+ /* We do not handle stores with a permutation. */
+ stmt_vec_info rep = SLP_TREE_REPRESENTATIVE (node);
+ if (STMT_VINFO_DATA_REF (rep)
+ && DR_IS_WRITE (STMT_VINFO_DATA_REF (rep)))
continue;
+ /* We cannot move a permute across an operation that is
+ not independent on lanes. Note this is an explicit
+ negative list since that's much shorter than the respective
+ positive one but it's critical to keep maintaining it. */
+ if (is_gimple_call (STMT_VINFO_STMT (rep)))
+ switch (gimple_call_combined_fn (STMT_VINFO_STMT (rep)))
+ {
+ case CFN_COMPLEX_ADD_ROT90:
+ case CFN_COMPLEX_ADD_ROT270:
+ case CFN_COMPLEX_MUL:
+ case CFN_COMPLEX_MUL_CONJ:
+ continue;
+ default:;
+ }
int perm = -1;
for (graph_edge *succ = slpg->vertices[idx].succ;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-25 9:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25 9:06 [gcc r11-8656] Fix SLP permute propagation error Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).