[gcc r12-2075] [Ada] Replace a question mark comment with assertion

[gcc r12-2075] [Ada] Replace a question mark comment with assertion

[Pierre-Marie de Rodat]

https://gcc.gnu.org/g:b1c4989d174cb22297a88f8873be95430ad62bcd

commit r12-2075-gb1c4989d174cb22297a88f8873be95430ad62bcd
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Tue May 11 14:11:12 2021 +0200

    [Ada] Replace a question mark comment with assertion
    
    gcc/ada/
    
            * lib.adb (Remove_Unit): Replace defensive code with an
            assertion.
            * par-load.adb (Load): Address a question mark in the comment.

Diff:
---
 gcc/ada/lib.adb      | 7 +++----
 gcc/ada/par-load.adb | 3 +--
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/gcc/ada/lib.adb b/gcc/ada/lib.adb
index 44aa5c61e60..44a4af0aed2 100644
--- a/gcc/ada/lib.adb
+++ b/gcc/ada/lib.adb
@@ -1174,10 +1174,9 @@ package body Lib is
 
    procedure Remove_Unit (U : Unit_Number_Type) is
    begin
-      if U = Units.Last then
-         Unit_Names.Set (Unit_Name (U), No_Unit);
-         Units.Decrement_Last;
-      end if;
+      pragma Assert (U = Units.Last);
+      Unit_Names.Set (Unit_Name (U), No_Unit);
+      Units.Decrement_Last;
    end Remove_Unit;
 
    ----------------------------------
diff --git a/gcc/ada/par-load.adb b/gcc/ada/par-load.adb
index fe8fede714c..39c445ea992 100644
--- a/gcc/ada/par-load.adb
+++ b/gcc/ada/par-load.adb
@@ -234,8 +234,7 @@ begin
          Error_Msg ("\\found unit $!", Loc);
       end if;
 
-      --  In both cases, remove the unit if it is the last unit (which it
-      --  normally (always?) will be) so that it is out of the way later.
+      --  In both cases, remove the unit so that it is out of the way later
 
       Remove_Unit (Cur_Unum);
    end if;