public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/marxin/heads/PR101425-fix-offloading-hint)] offloading: fix -foffload hinting
@ 2021-07-12  9:00 Martin Liska
  0 siblings, 0 replies; only message in thread
From: Martin Liska @ 2021-07-12  9:00 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:f64d87615ef851d64dc1f58abbf4cf5dc43afc43

commit f64d87615ef851d64dc1f58abbf4cf5dc43afc43
Author: Martin Liska <mliska@suse.cz>
Date:   Mon Jul 12 10:59:06 2021 +0200

    offloading: fix -foffload hinting
    
            sanitizer/101425
    
    gcc/ChangeLog:
    
            * gcc.c (check_offload_target_name): Call
              candidates_list_and_hint only if we have a candidate.

Diff:
---
 gcc/gcc.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gcc/gcc.c b/gcc/gcc.c
index f086dd47b91..16a8aa8f17b 100644
--- a/gcc/gcc.c
+++ b/gcc/gcc.c
@@ -4015,15 +4015,18 @@ check_offload_target_name (const char *target, ptrdiff_t len)
 
       error ("GCC is not configured to support %qs as offload target", target2);
 
-      const char *hint = candidates_list_and_hint (target2, s, candidates);
       if (candidates.is_empty ())
 	inform (UNKNOWN_LOCATION, "no offloading targets configured");
-      else if (hint)
-	inform (UNKNOWN_LOCATION,
-		"valid offload targets are: %s; did you mean %qs?", s, hint);
       else
-	inform (UNKNOWN_LOCATION, "valid offload targets are: %s", s);
-      XDELETEVEC (s);
+	{
+	  const char *hint = candidates_list_and_hint (target2, s, candidates);
+	  if (hint)
+	    inform (UNKNOWN_LOCATION,
+		    "valid offload targets are: %s; did you mean %qs?", s, hint);
+	  else
+	    inform (UNKNOWN_LOCATION, "valid offload targets are: %s", s);
+	  XDELETEVEC (s);
+	}
       return false;
     }
   return true;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-12  9:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12  9:00 [gcc(refs/users/marxin/heads/PR101425-fix-offloading-hint)] offloading: fix -foffload hinting Martin Liska

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).