public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-2306] Vect: correct rebase issue
@ 2021-07-14 18:01 Tamar Christina
  0 siblings, 0 replies; only message in thread
From: Tamar Christina @ 2021-07-14 18:01 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:4940166a15193d6583b320f2957af8720745b76c

commit r12-2306-g4940166a15193d6583b320f2957af8720745b76c
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Jul 14 19:00:59 2021 +0100

    Vect: correct rebase issue
    
    The lines being removed have been updated and merged into a new
    condition.  But when resolving some conflicts I accidentally
    reintroduced them causing some test failes.
    
    This removes them.
    
    Committed as the changes were previously approved in
    https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574977.html
    but the hunk was misapplied during a rebase.
    
    gcc/ChangeLog:
    
            * tree-vect-patterns.c (vect_recog_dot_prod_pattern):
            Remove erroneous line.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.dg/vect/vect-reduc-dot-11.c: Expect pass.
            * gcc.dg/vect/vect-reduc-dot-15.c: Likewise.
            * gcc.dg/vect/vect-reduc-dot-19.c: Likewise.
            * gcc.dg/vect/vect-reduc-dot-21.c: Likewise.

Diff:
---
 gcc/testsuite/gcc.dg/vect/vect-reduc-dot-11.c | 2 +-
 gcc/testsuite/gcc.dg/vect/vect-reduc-dot-15.c | 2 +-
 gcc/testsuite/gcc.dg/vect/vect-reduc-dot-19.c | 2 +-
 gcc/testsuite/gcc.dg/vect/vect-reduc-dot-21.c | 2 +-
 gcc/tree-vect-patterns.c                      | 6 ------
 5 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-11.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-11.c
index 5e3cfc92510..0f7cbbb87ef 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-11.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-11.c
@@ -9,5 +9,5 @@
 
 #include "vect-reduc-dot-9.c"
 
-/* { dg-final { scan-tree-dump-not "vect_recog_dot_prod_pattern: detected" "vect" } } */
+/* { dg-final { scan-tree-dump "vect_recog_dot_prod_pattern: detected" "vect" } } */
 /* { dg-final { scan-tree-dump-times "vectorized 1 loop" 1 "vect" { target vect_usdot_qi } } } */
diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-15.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-15.c
index 5a6fd1969ce..dc48f95a32b 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-15.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-15.c
@@ -9,5 +9,5 @@
 
 #include "vect-reduc-dot-9.c"
 
-/* { dg-final { scan-tree-dump-not "vect_recog_dot_prod_pattern: detected" "vect" } } */
+/* { dg-final { scan-tree-dump "vect_recog_dot_prod_pattern: detected" "vect" } } */
 /* { dg-final { scan-tree-dump-times "vectorized 1 loop" 1 "vect" { target vect_usdot_qi } } } */
diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-19.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-19.c
index 962b24ec204..dbeaaec24a1 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-19.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-19.c
@@ -49,4 +49,4 @@ main (void)
     __builtin_abort ();
 }
 
-/* { dg-final { scan-tree-dump-not "vect_recog_dot_prod_pattern: detected" "vect" } } */
+/* { dg-final { scan-tree-dump "vect_recog_dot_prod_pattern: detected" "vect" } } */
diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-21.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-21.c
index b5754bf7dde..6d08bf4478b 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-21.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-21.c
@@ -49,4 +49,4 @@ main (void)
     __builtin_abort ();
 }
 
-/* { dg-final { scan-tree-dump-not "vect_recog_dot_prod_pattern: detected" "vect" } } */
+/* { dg-final { scan-tree-dump "vect_recog_dot_prod_pattern: detected" "vect" } } */
diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c
index 71533e61c93..53ced5d08fb 100644
--- a/gcc/tree-vect-patterns.c
+++ b/gcc/tree-vect-patterns.c
@@ -1039,12 +1039,6 @@ vect_recog_dot_prod_pattern (vec_info *vinfo,
 	: TYPE_SIGN (unprom_mult.type) != TYPE_SIGN (half_type)))
     return NULL;
 
-  /* If there are two widening operations, make sure they agree on
-     the sign of the extension.  */
-  if (TYPE_PRECISION (unprom_mult.type) != TYPE_PRECISION (type)
-      && TYPE_SIGN (unprom_mult.type) != TYPE_SIGN (half_type))
-    return NULL;
-
   vect_pattern_detected ("vect_recog_dot_prod_pattern", last_stmt);
 
   tree half_vectype;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-14 18:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 18:01 [gcc r12-2306] Vect: correct rebase issue Tamar Christina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).