public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/trunk] Remove --param=threader-iterative.
@ 2021-08-02 15:00 Aldy Hernandez
  0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2021-08-02 15:00 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:cac2353f8b6424980a78fe224b20b2a70e98de51

commit cac2353f8b6424980a78fe224b20b2a70e98de51
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Mon Aug 2 15:12:30 2021 +0200

    Remove --param=threader-iterative.
    
    This was meant to be an internal construct, but I see folks are using
    it and submitting PRs against it.  Let's just remove this to avoid
    further confusion.
    
    Tested on x86-64 Linux.
    
    gcc/ChangeLog:
    
            PR tree-optimization/101724
            * params.opt: Remove --param=threader-iterative.
            * tree-ssa-threadbackward.c (pass_thread_jumps::execute): Remove
            iterative mode.

Diff:
---
 gcc/params.opt                |  4 ----
 gcc/tree-ssa-threadbackward.c | 18 ++----------------
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/gcc/params.opt b/gcc/params.opt
index f1f47b44215..aa2fb4047b6 100644
--- a/gcc/params.opt
+++ b/gcc/params.opt
@@ -1010,10 +1010,6 @@ Maximum depth of DFS walk used by modref escape analysis.
 Common Joined UInteger Var(param_modref_max_escape_points) Init(256) Param Optimization
 Maximum number of escape points tracked by modref per SSA-name.
 
--param=threader-iterative=
-Common Joined UInteger Var(param_threader_iterative) Init(0) Param Optimization
-Run backwards threader in iterative mode.
-
 -param=threader-mode=
 Common Joined Var(param_threader_mode) Enum(threader_mode) Init(THREADER_MODE_RANGER) Param Optimization
 --param=threader-mode=[legacy|ranger] Specifies the mode the backwards threader should run in.
diff --git a/gcc/tree-ssa-threadbackward.c b/gcc/tree-ssa-threadbackward.c
index 2c0e9751101..91ce443b1b2 100644
--- a/gcc/tree-ssa-threadbackward.c
+++ b/gcc/tree-ssa-threadbackward.c
@@ -1342,24 +1342,10 @@ pass_thread_jumps::execute (function *fun)
 {
   loop_optimizer_init (LOOPS_HAVE_PREHEADERS | LOOPS_HAVE_SIMPLE_LATCHES);
 
-  // Iterative mode is a testing construct and is not meant for public
-  // consumption.  It is OFF by default.
-  bool iterative = param_threader_iterative;
-
-  bool changed = false;
-  while (try_thread_blocks (fun))
-    {
-      changed = true;
-
-      if (!iterative)
-	break;
-
-      if ((param_threader_mode & THREADER_MODE_RANGER) == 0)
-	break;
-      cleanup_tree_cfg (TODO_update_ssa);
-    }
+  bool changed = try_thread_blocks (fun);
 
   loop_optimizer_finalize ();
+
   return changed ? TODO_cleanup_cfg : 0;
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-02 15:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 15:00 [gcc/trunk] Remove --param=threader-iterative Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).