public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-2876] i386: Fix up V32HImode permutations with -mno-avx512bw [PR101860]
@ 2021-08-12  9:27 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2021-08-12  9:27 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:04b4f3152593f85b05974528d1607619dd77d702

commit r12-2876-g04b4f3152593f85b05974528d1607619dd77d702
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Aug 12 11:26:57 2021 +0200

    i386: Fix up V32HImode permutations with -mno-avx512bw [PR101860]
    
    My patch from yesterday apparently broke some V32HImode permutations
    as the testcase shows.
    The first function assumed it would never be called in d->testing_p mode
    and so went right away into emitting the code.
    And the second one assumed V32HImode would never reach it, which now
    can for the !TARGET_AVX512BW case.  We don't have a instruction
    in that case though.
    
    2021-08-12  Jakub Jelinek  <jakub@redhat.com>
    
            PR target/101860
            * config/i386/i386-expand.c (ix86_expand_vec_one_operand_perm_avx512):
            If d->testing_p, return true after performing checks instead of
            actually expanding the insn.
            (expand_vec_perm_broadcast_1): Handle V32HImode - assert
            !TARGET_AVX512BW and return false.
    
            * gcc.target/i386/avx512f-pr101860.c: New test.

Diff:
---
 gcc/config/i386/i386-expand.c                    | 7 +++++++
 gcc/testsuite/gcc.target/i386/avx512f-pr101860.c | 5 +++++
 2 files changed, 12 insertions(+)

diff --git a/gcc/config/i386/i386-expand.c b/gcc/config/i386/i386-expand.c
index c708b33b786..a652b25f534 100644
--- a/gcc/config/i386/i386-expand.c
+++ b/gcc/config/i386/i386-expand.c
@@ -18116,6 +18116,9 @@ ix86_expand_vec_one_operand_perm_avx512 (struct expand_vec_perm_d *d)
       return false;
     }
 
+  if (d->testing_p)
+    return true;
+
   target = d->target;
   op0 = d->op0;
   for (int i = 0; i < d->nelt; ++i)
@@ -20481,6 +20484,10 @@ expand_vec_perm_broadcast_1 (struct expand_vec_perm_d *d)
       gcc_assert (!TARGET_AVX2 || d->perm[0]);
       return false;
 
+    case E_V32HImode:
+      gcc_assert (!TARGET_AVX512BW);
+      return false;
+
     default:
       gcc_unreachable ();
     }
diff --git a/gcc/testsuite/gcc.target/i386/avx512f-pr101860.c b/gcc/testsuite/gcc.target/i386/avx512f-pr101860.c
new file mode 100644
index 00000000000..1aadfa28ac8
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/avx512f-pr101860.c
@@ -0,0 +1,5 @@
+/* PR target/101860 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -mavx512f -mno-avx512bw" } */
+
+#include "../../gcc.dg/torture/vshuf-v32hi.c"


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-12  9:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12  9:27 [gcc r12-2876] i386: Fix up V32HImode permutations with -mno-avx512bw [PR101860] Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).