public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/marxin/heads/PR101949-ipa-modref-indirect-call)] IPA: MODREF should skip EAF_* flags for indirect calls
@ 2021-08-20 13:32 Martin Liska
  0 siblings, 0 replies; only message in thread
From: Martin Liska @ 2021-08-20 13:32 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:5f1a6d7e2e1eef344c50241a2e2f266ceedf655c

commit 5f1a6d7e2e1eef344c50241a2e2f266ceedf655c
Author: Martin Liska <mliska@suse.cz>
Date:   Fri Aug 20 14:27:13 2021 +0200

    IPA: MODREF should skip EAF_* flags for indirect calls
    
            PR 101949
    
    gcc/ChangeLog:
    
            * ipa-modref.c (analyze_ssa_name_flags): Do not propagate EAF
              flags arguments for indirect functions.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.dg/lto/pr101949_0.c: New test.
            * gcc.dg/lto/pr101949_1.c: New test.
    
    Co-Authored-By: Richard Biener <rguenther@suse.de>

Diff:
---
 gcc/ipa-modref.c                      |  3 +++
 gcc/testsuite/gcc.dg/lto/pr101949_0.c | 20 ++++++++++++++++++++
 gcc/testsuite/gcc.dg/lto/pr101949_1.c |  4 ++++
 3 files changed, 27 insertions(+)

diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index fafd804d4ba..380ba6926b9 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -1715,6 +1715,9 @@ analyze_ssa_name_flags (tree name, vec<modref_lattice> &lattice, int depth,
 	  else if (callee && !ipa && recursive_call_p (current_function_decl,
 						  callee))
 	    lattice[index].merge (0);
+	  /* Ignore indirect calls (PR101949).  */
+	  else if (callee == NULL_TREE)
+	    lattice[index].merge (0);
 	  else
 	    {
 	      int ecf_flags = gimple_call_flags (call);
diff --git a/gcc/testsuite/gcc.dg/lto/pr101949_0.c b/gcc/testsuite/gcc.dg/lto/pr101949_0.c
new file mode 100644
index 00000000000..142dffe8780
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/lto/pr101949_0.c
@@ -0,0 +1,20 @@
+/* { dg-lto-do run } */
+/* { dg-lto-options { "-O2 -fipa-pta -flto -flto-partition=1to1" } } */
+
+extern int bar (int (*)(int *), int *);
+
+static int x;
+
+static int __attribute__ ((noinline)) foo (int *p)
+{
+  *p = 1;
+  x = 0;
+  return *p;
+}
+
+int main ()
+{
+  if (bar (foo, &x) != 0)
+    __builtin_abort ();
+  return 0;
+}
diff --git a/gcc/testsuite/gcc.dg/lto/pr101949_1.c b/gcc/testsuite/gcc.dg/lto/pr101949_1.c
new file mode 100644
index 00000000000..871d15c9bfb
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/lto/pr101949_1.c
@@ -0,0 +1,4 @@
+int __attribute__((noinline,noclone)) bar (int (*fn)(int *), int *p)
+{
+  return fn (p);
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-20 13:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 13:32 [gcc(refs/users/marxin/heads/PR101949-ipa-modref-indirect-call)] IPA: MODREF should skip EAF_* flags for indirect calls Martin Liska

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).