public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-3337] Do not release state location until after path registry.
@ 2021-09-03 13:43 Aldy Hernandez
  0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2021-09-03 13:43 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:b237eb9dfdada49d3f2bdfa98aa4a0b67fc1829d

commit r12-3337-gb237eb9dfdada49d3f2bdfa98aa4a0b67fc1829d
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Fri Sep 3 10:11:28 2021 +0200

    Do not release state location until after path registry.
    
    We are popping state and then calling the registry code.  This causes
    the registry to have incorrect information.  This isn't visible in
    current trunk, but will be an issue when I submit further enhancements
    to the threading code.  However, it is a cleanup on its own so I am
    pushing it now.
    
    Tested on x86-64 Linux.
    
    gcc/ChangeLog:
    
            * tree-ssa-threadedge.c (jump_threader::thread_across_edge):
            Move pop until after a thread is registered.

Diff:
---
 gcc/tree-ssa-threadedge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/tree-ssa-threadedge.c b/gcc/tree-ssa-threadedge.c
index 37ee5c11be3..8a485125ff5 100644
--- a/gcc/tree-ssa-threadedge.c
+++ b/gcc/tree-ssa-threadedge.c
@@ -1155,9 +1155,9 @@ jump_threader::thread_across_edge (edge e)
     {
       propagate_threaded_block_debug_into (path->last ()->e->dest,
 					   e->dest);
-      m_state->pop ();
       BITMAP_FREE (visited);
       m_registry->register_jump_thread (path);
+      m_state->pop ();
       return;
     }
   else


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-03 13:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 13:43 [gcc r12-3337] Do not release state location until after path registry Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).