public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-3666] Fix PR bootstrap/102389: --with-build-config=bootstrap-lto is broken
@ 2021-09-19 17:30 Andrew Pinski
  0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2021-09-19 17:30 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:68aace4458364fee201889aaaedfce59beb972f2

commit r12-3666-g68aace4458364fee201889aaaedfce59beb972f2
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sat Sep 18 01:08:17 2021 +0000

    Fix PR bootstrap/102389: --with-build-config=bootstrap-lto is broken
    
    So the problem here is that now the lto-plugin requires NM that works
    with LTO to work so we need to pass down NM just like we do for ranlib
    and ar.
    
    OK? Bootstrapped and tested with --with-build-config=bootstrap-lto on aarch64-linux-gnu.
    Note you need to use binutils 2.35 or later too due to ttps://sourceware.org/PR25355
    (I will submit another patch to improve the installation instructions too).
    
    config/ChangeLog:
    
            PR bootstrap/102389
            * bootstrap-lto-lean.mk: Handle NM like RANLIB AND AR.
            * bootstrap-lto.mk: Likewise.

Diff:
---
 config/bootstrap-lto-lean.mk | 6 ++++--
 config/bootstrap-lto.mk      | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/config/bootstrap-lto-lean.mk b/config/bootstrap-lto-lean.mk
index 79cea50a4c6..42cb3394c70 100644
--- a/config/bootstrap-lto-lean.mk
+++ b/config/bootstrap-lto-lean.mk
@@ -9,9 +9,11 @@ STAGEfeedback_CFLAGS += -flto=jobserver
 # assumes the host supports the linker plugin
 LTO_AR = $$r/$(HOST_SUBDIR)/prev-gcc/gcc-ar$(exeext) -B$$r/$(HOST_SUBDIR)/prev-gcc/
 LTO_RANLIB = $$r/$(HOST_SUBDIR)/prev-gcc/gcc-ranlib$(exeext) -B$$r/$(HOST_SUBDIR)/prev-gcc/
+LTO_NM = $$r/$(HOST_SUBDIR)/prev-gcc/gcc-nm$(exeext) -B$$r/$(HOST_SUBDIR)/prev-gcc/
 
 LTO_EXPORTS = AR="$(LTO_AR)"; export AR; \
-	      RANLIB="$(LTO_RANLIB)"; export RANLIB;
-LTO_FLAGS_TO_PASS = AR="$(LTO_AR)" RANLIB="$(LTO_RANLIB)"
+	      RANLIB="$(LTO_RANLIB)"; export RANLIB; \
+	      NM="$(LTO_NM)"; export NM;
+LTO_FLAGS_TO_PASS = AR="$(LTO_AR)" RANLIB="$(LTO_RANLIB)" NM="$(LTO_NM)"
 
 do-compare = /bin/true
diff --git a/config/bootstrap-lto.mk b/config/bootstrap-lto.mk
index 4de07e5b226..1ddb1d870ba 100644
--- a/config/bootstrap-lto.mk
+++ b/config/bootstrap-lto.mk
@@ -9,10 +9,12 @@ STAGEfeedback_CFLAGS += -flto=jobserver -frandom-seed=1
 # assumes the host supports the linker plugin
 LTO_AR = $$r/$(HOST_SUBDIR)/prev-gcc/gcc-ar$(exeext) -B$$r/$(HOST_SUBDIR)/prev-gcc/
 LTO_RANLIB = $$r/$(HOST_SUBDIR)/prev-gcc/gcc-ranlib$(exeext) -B$$r/$(HOST_SUBDIR)/prev-gcc/
+LTO_NM = $$r/$(HOST_SUBDIR)/prev-gcc/gcc-nm$(exeext) -B$$r/$(HOST_SUBDIR)/prev-gcc/
 
 LTO_EXPORTS = AR="$(LTO_AR)"; export AR; \
-	      RANLIB="$(LTO_RANLIB)"; export RANLIB;
-LTO_FLAGS_TO_PASS = AR="$(LTO_AR)" RANLIB="$(LTO_RANLIB)"
+	      RANLIB="$(LTO_RANLIB)"; export RANLIB; \
+	      NM="$(LTO_NM)"; export NM;
+LTO_FLAGS_TO_PASS = AR="$(LTO_AR)" RANLIB="$(LTO_RANLIB)" NM="$(LTO_NM)"
 
 do-compare = $(SHELL) $(srcdir)/contrib/compare-lto $$f1 $$f2
 extra-compare = gcc/lto1$(exeext)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-19 17:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-19 17:30 [gcc r12-3666] Fix PR bootstrap/102389: --with-build-config=bootstrap-lto is broken Andrew Pinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).