public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-4226] c++: Add testcase for C++23 P2316R2 - consistent character literal encoding [PR102615]
@ 2021-10-07 13:17 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2021-10-07 13:17 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:348b426be3fc99453b42e79a18331c7bf24ee0dc

commit r12-4226-g348b426be3fc99453b42e79a18331c7bf24ee0dc
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Oct 7 15:16:13 2021 +0200

    c++: Add testcase for C++23 P2316R2 - consistent character literal encoding [PR102615]
    
    I believe we need no changes to the compiler for P2316R2, seems we treat
    character literals the same between preprocessor and C++ expressions,
    here is a testcase that should verify it.
    
    Note, seems the internal charset for GCC can be either UTF-8 or UTF-EBCDIC,
    but I bet it is very hard (at least for me) to actually test the latter.
    I'd guess one needs all system headers to be in EBCDIC and the gcc sources too.
    But looking around the source, I'm a little bit worried about the UTF-EBCDIC
    case.
    One is:
     #if  '\n' == 0x0A && ' ' == 0x20 && '0' == 0x30 \
        && 'A' == 0x41 && 'a' == 0x61 && '!' == 0x21
     #  define HOST_CHARSET HOST_CHARSET_ASCII
     #else
     # if '\n' == 0x15 && ' ' == 0x40 && '0' == 0xF0 \
        && 'A' == 0xC1 && 'a' == 0x81 && '!' == 0x5A
     #  define HOST_CHARSET HOST_CHARSET_EBCDIC
     # else
     #  define HOST_CHARSET HOST_CHARSET_UNKNOWN
     # endif
     #endif
    in include/safe-ctype.h, does that mean we only support EBCDIC if -funsigned-char
    and otherwise fail to build gcc?  Because with -fsigned-char, '0' is -0x10
    rather than 0xF0, 'A' is -0x3F rather than 0xC1 and 'a' is -0x7F rather than
    0x81.
    And another thing, if HOST_CHARSET == HOST_CHARSET_EBCDIC, how does the libcpp/lex.c
    static const cppchar_t utf8_signifier = 0xC0;
    ...
          if (*buffer->cur >= utf8_signifier)
            {
              if (_cpp_valid_utf8 (pfile, &buffer->cur, buffer->rlimit, 1 + !first,
                                   state, &s))
                return true;
            }
    work?  Because in UTF-EBCDIC, >= 0xC0 isn't the right test for start of
    multi-byte character, it is more complicated and seems _cpp_valid_utf8
    assumes UTF-8 as the host charset.
    
    2021-10-07  Jakub Jelinek  <jakub@redhat.com>
    
            PR c++/102615
            * g++.dg/cpp23/charlit-encoding1.C: New testcase for C++23 P2316R2.

Diff:
---
 gcc/testsuite/g++.dg/cpp23/charlit-encoding1.C | 33 ++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gcc/testsuite/g++.dg/cpp23/charlit-encoding1.C b/gcc/testsuite/g++.dg/cpp23/charlit-encoding1.C
new file mode 100644
index 00000000000..736f022ea95
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp23/charlit-encoding1.C
@@ -0,0 +1,33 @@
+// PR c++/102615 - P2316R2 - Consistent character literal encoding
+// { dg-do run }
+
+extern "C" void abort ();
+
+int
+main ()
+{
+#if ' ' == 0x20
+  if (' ' != 0x20)
+    abort ();
+#elif ' ' == 0x40
+  if (' ' != 0x40)
+    abort ();
+#else
+  if (' ' == 0x20 || ' ' == 0x40)
+    abort ();
+#endif
+#if 'a' == 0x61
+  if ('a' != 0x61)
+    abort ();
+#elif 'a' == 0x81
+  if ('a' != 0x81)
+    abort ();
+#elif 'a' == -0x7F
+  if ('a' != -0x7F)
+    abort ();
+#else
+  if ('a' == 0x61 || 'a' == 0x81 || 'a' == -0x7F)
+    abort ();
+#endif
+  return 0;
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-07 13:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 13:17 [gcc r12-4226] c++: Add testcase for C++23 P2316R2 - consistent character literal encoding [PR102615] Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).