public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Roger Sayle <sayle@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-4449] Allow early sets of SSE hard registers from standard_sse_constant_p.
Date: Fri, 15 Oct 2021 18:10:52 +0000 (GMT)	[thread overview]
Message-ID: <20211015181052.6A0CA3858C60@sourceware.org> (raw)

https://gcc.gnu.org/g:730f52e05a1fb5c8cd92e352e9b191a6332be5c2

commit r12-4449-g730f52e05a1fb5c8cd92e352e9b191a6332be5c2
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Fri Oct 15 19:09:25 2021 +0100

    Allow early sets of SSE hard registers from standard_sse_constant_p.
    
    My previous patch, which was intended to reduce the differences seen by
    the combination of -march=cascadelake and -m32, has additionally found
    some more instances where this combination behaves differently to regular
    x86_64-pc-linux-gnu.  The middle-end always, and backends usually, use
    emit_move_insn to emit/expand move instructions allowing the backend
    control over placing things in constant pools, adding REG_EQUAL notes,
    and so on.  Several of the AVX512 built-in expanders bypass this logic,
    and instead generate moves directly using emit_insn(gen_rtx_SET (dst,src)).
    
    For example, i386-expand.c line 12004 contains:
          for (i = 0; i < 8; i++)
            emit_insn (gen_rtx_SET (xmm_regs[i], const0_rtx));
    
    I suspect that in this case, loading of standard_sse_constant_p, my
    change to require loading of likely spilled hard registers via a
    pseudo is perhaps overly strict, so this patch/fix reallows these
    immediate constants values to be loaded directly prior to reload.
    
    2021-10-15  Roger Sayle  <roger@nextmovesoftware.com>
    
    gcc/ChangeLog
            * config/i386/i386.c (ix86_hardreg_mov_ok): For vector modes,
            allow standard_sse_constant_p immediate constants.

Diff:
---
 gcc/config/i386/i386.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index fb656094e9e..9cc903e826b 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -19303,7 +19303,9 @@ ix86_hardreg_mov_ok (rtx dst, rtx src)
   /* Avoid complex sets of likely_spilled hard registers before reload.  */
   if (REG_P (dst) && HARD_REGISTER_P (dst)
       && !REG_P (src) && !MEM_P (src)
-      && !x86_64_immediate_operand (src, GET_MODE (dst))
+      && !(VECTOR_MODE_P (GET_MODE (dst))
+	   ? standard_sse_constant_p (src, GET_MODE (dst))
+	   : x86_64_immediate_operand (src, GET_MODE (dst)))
       && ix86_class_likely_spilled_p (REGNO_REG_CLASS (REGNO (dst)))
       && !reload_completed)
     return false;


                 reply	other threads:[~2021-10-15 18:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015181052.6A0CA3858C60@sourceware.org \
    --to=sayle@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).