public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-9164] amdgcn: Mark s_mulk_i32 as clobbering SCC
@ 2021-10-18 8:57 Tobias Burnus
0 siblings, 0 replies; only message in thread
From: Tobias Burnus @ 2021-10-18 8:57 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:5b85107d3ce704bf5f6fff63d1736ddc00265d24
commit r11-9164-g5b85107d3ce704bf5f6fff63d1736ddc00265d24
Author: Julian Brown <julian@codesourcery.com>
Date: Mon Jun 28 06:58:52 2021 -0700
amdgcn: Mark s_mulk_i32 as clobbering SCC
The s_mulk_i32 instruction sets the SCC status register according to
whether the multiplication overflows, but that is not currently modelled
in the GCN backend. AFAIK this is a latent bug and hasn't been noticed
"in the wild", but it should be fixed.
2021-06-29 Julian Brown <julian@codesourcery.com>
gcc/
* config/gcn/gcn.md (mulsi3): Make s_mulk_i32 variant clobber SCC.
(cherry picked from commit 5c127c4cac308429cba483a2ac4e175c2ab26165)
Diff:
---
gcc/config/gcn/gcn.md | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gcc/config/gcn/gcn.md b/gcc/config/gcn/gcn.md
index 57a3a58c7d6..d41ce6c80a2 100644
--- a/gcc/config/gcn/gcn.md
+++ b/gcc/config/gcn/gcn.md
@@ -1372,10 +1372,13 @@
; Vector multiply has vop3a encoding, but no corresponding vop2a, so no long
; immediate.
+; The "s_mulk_i32" variant sets SCC to indicate overflow (which we don't care
+; about here, but we need to indicate the clobbering).
(define_insn "mulsi3"
[(set (match_operand:SI 0 "register_operand" "= Sg,Sg, Sg, v")
(mult:SI (match_operand:SI 1 "gcn_alu_operand" "%SgA, 0,SgA, v")
- (match_operand:SI 2 "gcn_alu_operand" " SgA, J, B,vASv")))]
+ (match_operand:SI 2 "gcn_alu_operand" " SgA, J, B,vASv")))
+ (clobber (match_scratch:BI 3 "=X,cs, X, X"))]
""
"@
s_mul_i32\t%0, %1, %2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-18 8:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 8:57 [gcc r11-9164] amdgcn: Mark s_mulk_i32 as clobbering SCC Tobias Burnus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).