public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-4606] Revert the avoid threading circular paths commit.
@ 2021-10-21 11:24 Aldy Hernandez
  0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2021-10-21 11:24 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:d6a3c0cfb852dbeee4255e3588e9a1f52e376042

commit r12-4606-gd6a3c0cfb852dbeee4255e3588e9a1f52e376042
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Thu Oct 21 13:18:49 2021 +0200

    Revert the avoid threading circular paths commit.
    
    I've tested this patch on the wrong tree, and picked up the test changes
    in a pending patch, without which this patch is no longer obvious.
    Plus, it causes a regression in an invalid test I've recommended we remove.
    
    I'm reverting this patch until the dependencies are reviewed.
    
    Sorry for the noise.
    
    gcc/ChangeLog:
    
            * tree-ssa-threadbackward.c
            (back_threader::maybe_register_path): Remove circular paths check.

Diff:
---
 gcc/tree-ssa-threadbackward.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gcc/tree-ssa-threadbackward.c b/gcc/tree-ssa-threadbackward.c
index 38913b06717..d94e3b962db 100644
--- a/gcc/tree-ssa-threadbackward.c
+++ b/gcc/tree-ssa-threadbackward.c
@@ -140,10 +140,6 @@ back_threader::maybe_register_path ()
 
   if (taken_edge && taken_edge != UNREACHABLE_EDGE)
     {
-      // Avoid circular paths.
-      if (m_visited_bbs.contains (taken_edge->dest))
-	return UNREACHABLE_EDGE;
-
       bool irreducible = false;
       bool profitable
 	= m_profit.profitable_path_p (m_path, m_name, taken_edge, &irreducible);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-21 11:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 11:24 [gcc r12-4606] Revert the avoid threading circular paths commit Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).