public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-5061] Restore 'GOMP_OPENACC_DIM' environment variable parsing
@ 2021-11-09 16:03 Thomas Schwinge
  0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2021-11-09 16:03 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:00c9ce13a64e324dabd8dfd236882919a3119479

commit r12-5061-g00c9ce13a64e324dabd8dfd236882919a3119479
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Fri Nov 5 14:42:21 2021 +0100

    Restore 'GOMP_OPENACC_DIM' environment variable parsing
    
    ... that got broken by recent commit c057ed9c52c6a63a1a692268f916b1a9131cd4b7
    "openmp: Fix up strtoul and strtoull uses in libgomp", resulting in spurious
    FAILs for tests specifying 'dg-set-target-env-var "GOMP_OPENACC_DIM" "[...]"'.
    
            libgomp/
            * env.c (parse_gomp_openacc_dim): Restore parsing.

Diff:
---
 libgomp/env.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgomp/env.c b/libgomp/env.c
index df10ff656b6..75018e8c252 100644
--- a/libgomp/env.c
+++ b/libgomp/env.c
@@ -1243,7 +1243,7 @@ parse_gomp_openacc_dim (void)
 
       errno = 0;
       val = strtol (pos, &eptr, 10);
-      if (errno || eptr != pos || val < 0 || (unsigned)val != val)
+      if (errno || eptr == pos || val < 0 || (unsigned)val != val)
 	break;
 
       goacc_default_dims[i] = (int)val;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-09 16:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 16:03 [gcc r12-5061] Restore 'GOMP_OPENACC_DIM' environment variable parsing Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).