public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-5201] Fix ICE in tree-ssa-structalias.c
@ 2021-11-12 15:35 Jan Hubicka
  0 siblings, 0 replies; only message in thread
From: Jan Hubicka @ 2021-11-12 15:35 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:4526ec20f17a6182f754da9460d9d944dd123cc0

commit r12-5201-g4526ec20f17a6182f754da9460d9d944dd123cc0
Author: Jan Hubicka <jh@suse.cz>
Date:   Fri Nov 12 16:34:03 2021 +0100

    Fix ICE in tree-ssa-structalias.c
    
            PR tree-optimization/103175
            * ipa-modref.c (modref_lattice::merge): Add sanity check.
            (callee_to_caller_flags): Make flags adjustment sane.
            (modref_eaf_analysis::analyze_ssa_name): Likewise.

Diff:
---
 gcc/ipa-modref.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index 44b3427a202..e999c2c5d1e 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -1681,6 +1681,13 @@ modref_lattice::merge (int f)
 {
   if (f & EAF_UNUSED)
     return false;
+  /* Check that flags seems sane: if function does not read the parameter
+     it can not access it indirectly.  */
+  gcc_checking_assert (!(f & EAF_NO_DIRECT_READ)
+		       || ((f & EAF_NO_INDIRECT_READ)
+			   && (f & EAF_NO_INDIRECT_CLOBBER)
+			   && (f & EAF_NO_INDIRECT_ESCAPE)
+			   && (f & EAF_NOT_RETURNED_INDIRECTLY)));
   if ((flags & f) != flags)
     {
       flags &= f;
@@ -1889,9 +1896,11 @@ callee_to_caller_flags (int call_flags, bool ignore_stores,
       if (!(call_flags & EAF_NO_DIRECT_ESCAPE))
 	lattice.merge (~(EAF_NOT_RETURNED_DIRECTLY
 			 | EAF_NOT_RETURNED_INDIRECTLY
+			 | EAF_NO_DIRECT_READ
 			 | EAF_UNUSED));
       if (!(call_flags & EAF_NO_INDIRECT_ESCAPE))
 	lattice.merge (~(EAF_NOT_RETURNED_INDIRECTLY
+			 | EAF_NO_DIRECT_READ
 			 | EAF_UNUSED));
     }
   else
@@ -2033,11 +2042,11 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
 			  if (!(call_flags & (EAF_NOT_RETURNED_DIRECTLY
 					      | EAF_UNUSED)))
 			    m_lattice[index].merge (~(EAF_NO_DIRECT_ESCAPE
-						      | EAF_NO_INDIRECT_ESCAPE
 						      | EAF_UNUSED));
 			  if (!(call_flags & (EAF_NOT_RETURNED_INDIRECTLY
 					      | EAF_UNUSED)))
 			    m_lattice[index].merge (~(EAF_NO_INDIRECT_ESCAPE
+						      | EAF_NO_DIRECT_READ
 						      | EAF_UNUSED));
 			  call_flags = callee_to_caller_flags
 					   (call_flags, false,


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-12 15:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 15:35 [gcc r12-5201] Fix ICE in tree-ssa-structalias.c Jan Hubicka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).