[gcc r12-5221] Fix wrong code with modref and some builtins.

[gcc r12-5221] Fix wrong code with modref and some builtins.

[Jan Hubicka]

https://gcc.gnu.org/g:2f3d43a35155685b1795b4392e20e1c14a33c38f

commit r12-5221-g2f3d43a35155685b1795b4392e20e1c14a33c38f
Author: Jan Hubicka <jh@suse.cz>
Date:   Sat Nov 13 01:51:25 2021 +0100

    Fix wrong code with modref and some builtins.
    
    ipa-modref gets confused by EAF flags of memcpy becuase parameter 1 is
    escaping but used only directly.  In modref we do not track values saved to
    memory and thus we clear all other flags on each store.  This needs to also
    happen when called function escapes parameter.
    
    gcc/ChangeLog:
    
            PR tree-optimization/103182
            * ipa-modref.c (callee_to_caller_flags): Fix merging of flags.
            (modref_eaf_analysis::analyze_ssa_name): Fix merging of flags.

Diff:
---
 gcc/ipa-modref.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index e999c2c5d1e..90985cc1326 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -1888,19 +1888,18 @@ callee_to_caller_flags (int call_flags, bool ignore_stores,
      that is not the same as caller returning it.  */
   call_flags |= EAF_NOT_RETURNED_DIRECTLY
 		| EAF_NOT_RETURNED_INDIRECTLY;
-  /* TODO: We miss return value propagation.
-     Be conservative and if value escapes to memory
-     also mark it as escaping.  */
   if (!ignore_stores && !(call_flags & EAF_UNUSED))
     {
+      /* If value escapes we are no longer able to track what happens
+	 with it because we can read it from the escaped location
+	 anytime.  */
       if (!(call_flags & EAF_NO_DIRECT_ESCAPE))
-	lattice.merge (~(EAF_NOT_RETURNED_DIRECTLY
-			 | EAF_NOT_RETURNED_INDIRECTLY
-			 | EAF_NO_DIRECT_READ
-			 | EAF_UNUSED));
-      if (!(call_flags & EAF_NO_INDIRECT_ESCAPE))
+	lattice.merge (0);
+      else if (!(call_flags & EAF_NO_INDIRECT_ESCAPE))
 	lattice.merge (~(EAF_NOT_RETURNED_INDIRECTLY
 			 | EAF_NO_DIRECT_READ
+			 | EAF_NO_INDIRECT_READ
+			 | EAF_NO_INDIRECT_CLOBBER
 			 | EAF_UNUSED));
     }
   else
@@ -2036,18 +2035,17 @@ modref_eaf_analysis::analyze_ssa_name (tree name)
 			 not_returned and escape has same meaning.
 			 However passing arg to return slot is different.  If
 			 the callee's return slot is returned it means that
-			 arg is written to itself which is an escape.  */
+			 arg is written to itself which is an escape.
+			 Since we do not track the memory it is written to we
+			 need to give up on analysisng it.  */
 		      if (!isretslot)
 			{
 			  if (!(call_flags & (EAF_NOT_RETURNED_DIRECTLY
 					      | EAF_UNUSED)))
-			    m_lattice[index].merge (~(EAF_NO_DIRECT_ESCAPE
-						      | EAF_UNUSED));
-			  if (!(call_flags & (EAF_NOT_RETURNED_INDIRECTLY
-					      | EAF_UNUSED)))
-			    m_lattice[index].merge (~(EAF_NO_INDIRECT_ESCAPE
-						      | EAF_NO_DIRECT_READ
-						      | EAF_UNUSED));
+			    m_lattice[index].merge (0);
+			  else gcc_checking_assert
+				(call_flags & (EAF_NOT_RETURNED_INDIRECTLY
+					       | EAF_UNUSED));
 			  call_flags = callee_to_caller_flags
 					   (call_flags, false,
 					    m_lattice[index]);