public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/aoliva/heads/testme)] Revert "[Ada] introduce stack scrub (strub) feature"
@ 2021-11-16 3:48 Alexandre Oliva
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Oliva @ 2021-11-16 3:48 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:2d0144efbce4b90991b9de64d8c25cf8cc22f905
commit 2d0144efbce4b90991b9de64d8c25cf8cc22f905
Author: Alexandre Oliva <oliva@gnu.org>
Date: Fri Oct 8 02:36:32 2021 -0300
Revert "[Ada] introduce stack scrub (strub) feature"
This reverts commit a23e02091ef789192db85112f2b6b0dd2724d95c.
Diff:
---
.../doc/gnat_rm/security_hardening_features.rst | 82 --------------------
gcc/ada/gcc-interface/utils.c | 12 ---
gcc/ada/libgnat/a-except.adb | 90 ----------------------
gcc/ada/libgnat/a-except.ads | 9 ---
gcc/ada/libgnat/s-arit128.ads | 7 --
gcc/ada/libgnat/s-arit64.ads | 7 --
gcc/ada/libgnat/s-secsta.ads | 5 --
7 files changed, 212 deletions(-)
diff --git a/gcc/ada/doc/gnat_rm/security_hardening_features.rst b/gcc/ada/doc/gnat_rm/security_hardening_features.rst
index cf76938d91d..a205d555c44 100644
--- a/gcc/ada/doc/gnat_rm/security_hardening_features.rst
+++ b/gcc/ada/doc/gnat_rm/security_hardening_features.rst
@@ -7,88 +7,6 @@ Security Hardening Features
This chapter describes Ada extensions aimed at security hardening that
are provided by GNAT.
-.. Register Scrubbing:
-
-Register Scrubbing
-==================
-
-GNAT can generate code to zero-out hardware registers before returning
-from a subprogram.
-
-It can be enabled with the *-fzero-call-used-regs* command line
-option, to affect all subprograms in a compilation, and with a
-:samp:`Machine_Attribute` pragma, to affect only specific subprograms.
-
-.. code-block:: ada
-
- procedure Foo;
- pragma Machine_Attribute (Foo, "zero_call_used_regs", "used");
- -- Before returning, Foo scrubs only call-clobbered registers
- -- that it uses itself.
-
- function Bar return Integer;
- pragma Machine_Attribute (Bar, "zero_call_used_regs", "all");
- -- Before returning, Bar scrubs all call-clobbered registers.
-
-
-For usage and more details on the command line option, and on the
-``zero_call_used_regs`` attribute, see :title:`Using the GNU Compiler
-Collection (GCC)`.
-
-
-.. Stack Scrubbing:
-
-Stack Scrubbing
-===============
-
-GNAT can generate code to zero-out stack frames used by subprograms.
-
-It can be activated with the :samp:`Machine_Attribute` pragma, on
-specific subprograms and variables.
-
-.. code-block:: ada
-
- function Foo returns Integer;
- pragma Machine_Attribute (Foo, "strub");
- -- Foo and its callers are modified so as to scrub the stack
- -- space used by Foo after it returns.
-
- procedure Bar;
- pragma Machine_Attribute (Bar, "strub", "internal");
- -- Bar is turned into a wrapper for its original body,
- -- and they scrub the stack used by the original body.
-
- Var : Integer;
- pragma Machine_Attribute (Var, "strub");
- -- Reading from Var in a subprogram enables stack scrubbing
- -- of the stack space used by the subprogram.
-
-
-There are also *-fstrub* command line options to control default
-settings. For usage and more details on the command line option, and
-on the ``strub`` attribute, see :title:`Using the GNU Compiler
-Collection (GCC)`.
-
-Note that Ada secondary stacks are not scrubbed. The restriction
-``No_Secondary_Stack`` avoids their use, and thus their accidental
-preservation of data that should be scrubbed.
-
-Also note that the machine attribute is not integrated in the Ada type
-system. Though it may modify subprogram and variable interfaces, it
-is not fully reflected in Ada types, ``Access`` attributes, renaming
-and overriding. Every access type, renaming, and overriding and
-overridden dispatching operations that may refer to an entity with an
-attribute-modified interface must be annotated with the same
-interface-modifying attribute, or with an interface-compatible one.
-
-Even then, the pragma is currently only functional when applied to
-subprograms and scalar variables; other uses, such as directly on
-types and subtypes, may be silently ignored. Specifically, it is not
-currently recommended to rely on any effects this pragma might be
-expected to have when calling subprograms through access-to-subprogram
-variables.
-
-
.. Hardened Conditionals:
Hardened Conditionals
diff --git a/gcc/ada/gcc-interface/utils.c b/gcc/ada/gcc-interface/utils.c
index ab5ca5b1714..be3f107926d 100644
--- a/gcc/ada/gcc-interface/utils.c
+++ b/gcc/ada/gcc-interface/utils.c
@@ -94,7 +94,6 @@ static tree handle_sentinel_attribute (tree *, tree, tree, int, bool *);
static tree handle_noreturn_attribute (tree *, tree, tree, int, bool *);
static tree handle_stack_protect_attribute (tree *, tree, tree, int, bool *);
static tree handle_no_stack_protector_attribute (tree *, tree, tree, int, bool *);
-static tree handle_strub_attribute (tree *, tree, tree, int, bool *);
static tree handle_noinline_attribute (tree *, tree, tree, int, bool *);
static tree handle_noclone_attribute (tree *, tree, tree, int, bool *);
static tree handle_noicf_attribute (tree *, tree, tree, int, bool *);
@@ -158,8 +157,6 @@ const struct attribute_spec gnat_internal_attribute_table[] =
{ "no_stack_protector",0, 0, true, false, false, false,
handle_no_stack_protector_attribute,
attr_stack_protect_exclusions },
- { "strub", 0, 1, false, true, false, true,
- handle_strub_attribute, NULL },
{ "noinline", 0, 0, true, false, false, false,
handle_noinline_attribute, NULL },
{ "noclone", 0, 0, true, false, false, false,
@@ -6605,15 +6602,6 @@ handle_no_stack_protector_attribute (tree *node, tree name, tree, int,
return NULL_TREE;
}
-/* Handle a "strub" attribute; arguments as in
- struct attribute_spec.handler. */
-
-static tree
-handle_strub_attribute (tree *, tree, tree, int, bool *no_add_attrs)
-{
- *no_add_attrs = true;
- return NULL_TREE;
-}
/* Handle a "noinline" attribute; arguments as in
struct attribute_spec.handler. */
diff --git a/gcc/ada/libgnat/a-except.adb b/gcc/ada/libgnat/a-except.adb
index 631c35aa92c..5658adf6c95 100644
--- a/gcc/ada/libgnat/a-except.adb
+++ b/gcc/ada/libgnat/a-except.adb
@@ -629,96 +629,6 @@ package body Ada.Exceptions is
pragma No_Return (Rcheck_CE_Invalid_Data_Ext);
pragma No_Return (Rcheck_CE_Range_Check_Ext);
- -- Make all of these procedures callable from strub contexts.
- -- These attributes are not visible to callers; they are made
- -- visible in trans.c:build_raise_check.
-
- pragma Machine_Attribute (Rcheck_CE_Access_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Null_Access_Parameter,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Discriminant_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Divide_By_Zero,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Explicit_Raise,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Index_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Invalid_Data,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Length_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Null_Exception_Id,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Null_Not_Allowed,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Overflow_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Partition_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Range_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Tag_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Access_Before_Elaboration,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Accessibility_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Address_Of_Intrinsic,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Aliased_Parameters,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_All_Guards_Closed,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Bad_Predicated_Generic_Type,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Build_In_Place_Mismatch,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Current_Task_In_Entry_Body,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Duplicated_Entry_Address,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Explicit_Raise,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Implicit_Return,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Misaligned_Address_Value,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Missing_Return,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Non_Transportable_Actual,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Overlaid_Controlled_Object,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Potentially_Blocking_Operation,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Stream_Operation_Not_Allowed,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Stubbed_Subprogram_Called,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Unchecked_Union_Restriction,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Finalize_Raised_Exception,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Empty_Storage_Pool,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Explicit_Raise,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Infinite_Recursion,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Object_Too_Large,
- "strub", "callable");
-
- pragma Machine_Attribute (Rcheck_CE_Access_Check_Ext,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Index_Check_Ext,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Invalid_Data_Ext,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Range_Check_Ext,
- "strub", "callable");
-
---------------------------------------------
-- Reason Strings for Run-Time Check Calls --
---------------------------------------------
diff --git a/gcc/ada/libgnat/a-except.ads b/gcc/ada/libgnat/a-except.ads
index 1608e79eee4..2b27adb6ca1 100644
--- a/gcc/ada/libgnat/a-except.ads
+++ b/gcc/ada/libgnat/a-except.ads
@@ -184,15 +184,6 @@ private
-- Raise_Exception_Always if it can determine this is the case. The Export
-- allows this routine to be accessed from Pure units.
- -- Make these callable from strub contexts.
- pragma Machine_Attribute (Raise_Exception_Always,
- "strub", "callable");
- pragma Machine_Attribute (Raise_Exception,
- "strub", "callable");
- -- This property should arguably be visible to callers, but let's
- -- keep it private for now. In practice, it doesn't matter, since
- -- it's only checked in the back end.
-
procedure Raise_From_Controlled_Operation (X : Exception_Occurrence);
pragma No_Return (Raise_From_Controlled_Operation);
pragma Export
diff --git a/gcc/ada/libgnat/s-arit128.ads b/gcc/ada/libgnat/s-arit128.ads
index fa6fedcbc11..6213cfb569a 100644
--- a/gcc/ada/libgnat/s-arit128.ads
+++ b/gcc/ada/libgnat/s-arit128.ads
@@ -81,11 +81,4 @@ package System.Arith_128 is
-- then Q is the rounded quotient. The remainder R is not affected by the
-- setting of the Round flag.
-private
- -- Make it callable from strub contexts.
- -- There is a matching setting in trans.c,
- -- for calls issued by Gigi.
- pragma Machine_Attribute (Multiply_With_Ovflo_Check128,
- "strub", "callable");
-
end System.Arith_128;
diff --git a/gcc/ada/libgnat/s-arit64.ads b/gcc/ada/libgnat/s-arit64.ads
index ca71a2c4074..fbfd0f65468 100644
--- a/gcc/ada/libgnat/s-arit64.ads
+++ b/gcc/ada/libgnat/s-arit64.ads
@@ -180,11 +180,4 @@ is
Round : Boolean) renames Double_Divide64;
-- Renamed procedure to preserve compatibility with earlier versions
-private
- -- Make it callable from strub contexts.
- -- There is a matching setting in trans.c,
- -- for calls issued by Gigi.
- pragma Machine_Attribute (Multiply_With_Ovflo_Check64,
- "strub", "callable");
-
end System.Arith_64;
diff --git a/gcc/ada/libgnat/s-secsta.ads b/gcc/ada/libgnat/s-secsta.ads
index 6648c233d4c..7d6b1b9a90e 100644
--- a/gcc/ada/libgnat/s-secsta.ads
+++ b/gcc/ada/libgnat/s-secsta.ads
@@ -440,9 +440,4 @@ private
function Get_Stack_Info (Stack : SS_Stack_Ptr) return Stack_Info;
-- Obtain the information attributes of secondary stack Stack
- pragma Machine_Attribute (SS_Allocate, "strub", "callable");
- pragma Machine_Attribute (SS_Mark, "strub", "callable");
- pragma Machine_Attribute (SS_Release, "strub", "callable");
- -- Enable these to be called from within strub contexts.
-
end System.Secondary_Stack;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [gcc(refs/users/aoliva/heads/testme)] Revert "[Ada] introduce stack scrub (strub) feature"
@ 2022-04-06 15:02 Alexandre Oliva
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Oliva @ 2022-04-06 15:02 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:ba19879f3a19002e034563d998e2350a246b650f
commit ba19879f3a19002e034563d998e2350a246b650f
Author: Alexandre Oliva <oliva@gnu.org>
Date: Fri Oct 8 02:36:32 2021 -0300
Revert "[Ada] introduce stack scrub (strub) feature"
This reverts commit a23e02091ef789192db85112f2b6b0dd2724d95c.
Diff:
---
.../doc/gnat_rm/security_hardening_features.rst | 82 --------------------
gcc/ada/gcc-interface/utils.cc | 12 ---
gcc/ada/libgnat/a-except.adb | 90 ----------------------
gcc/ada/libgnat/a-except.ads | 9 ---
gcc/ada/libgnat/s-arit128.ads | 7 --
gcc/ada/libgnat/s-arit64.ads | 7 --
gcc/ada/libgnat/s-secsta.ads | 5 --
7 files changed, 212 deletions(-)
diff --git a/gcc/ada/doc/gnat_rm/security_hardening_features.rst b/gcc/ada/doc/gnat_rm/security_hardening_features.rst
index cf76938d91d..a205d555c44 100644
--- a/gcc/ada/doc/gnat_rm/security_hardening_features.rst
+++ b/gcc/ada/doc/gnat_rm/security_hardening_features.rst
@@ -7,88 +7,6 @@ Security Hardening Features
This chapter describes Ada extensions aimed at security hardening that
are provided by GNAT.
-.. Register Scrubbing:
-
-Register Scrubbing
-==================
-
-GNAT can generate code to zero-out hardware registers before returning
-from a subprogram.
-
-It can be enabled with the *-fzero-call-used-regs* command line
-option, to affect all subprograms in a compilation, and with a
-:samp:`Machine_Attribute` pragma, to affect only specific subprograms.
-
-.. code-block:: ada
-
- procedure Foo;
- pragma Machine_Attribute (Foo, "zero_call_used_regs", "used");
- -- Before returning, Foo scrubs only call-clobbered registers
- -- that it uses itself.
-
- function Bar return Integer;
- pragma Machine_Attribute (Bar, "zero_call_used_regs", "all");
- -- Before returning, Bar scrubs all call-clobbered registers.
-
-
-For usage and more details on the command line option, and on the
-``zero_call_used_regs`` attribute, see :title:`Using the GNU Compiler
-Collection (GCC)`.
-
-
-.. Stack Scrubbing:
-
-Stack Scrubbing
-===============
-
-GNAT can generate code to zero-out stack frames used by subprograms.
-
-It can be activated with the :samp:`Machine_Attribute` pragma, on
-specific subprograms and variables.
-
-.. code-block:: ada
-
- function Foo returns Integer;
- pragma Machine_Attribute (Foo, "strub");
- -- Foo and its callers are modified so as to scrub the stack
- -- space used by Foo after it returns.
-
- procedure Bar;
- pragma Machine_Attribute (Bar, "strub", "internal");
- -- Bar is turned into a wrapper for its original body,
- -- and they scrub the stack used by the original body.
-
- Var : Integer;
- pragma Machine_Attribute (Var, "strub");
- -- Reading from Var in a subprogram enables stack scrubbing
- -- of the stack space used by the subprogram.
-
-
-There are also *-fstrub* command line options to control default
-settings. For usage and more details on the command line option, and
-on the ``strub`` attribute, see :title:`Using the GNU Compiler
-Collection (GCC)`.
-
-Note that Ada secondary stacks are not scrubbed. The restriction
-``No_Secondary_Stack`` avoids their use, and thus their accidental
-preservation of data that should be scrubbed.
-
-Also note that the machine attribute is not integrated in the Ada type
-system. Though it may modify subprogram and variable interfaces, it
-is not fully reflected in Ada types, ``Access`` attributes, renaming
-and overriding. Every access type, renaming, and overriding and
-overridden dispatching operations that may refer to an entity with an
-attribute-modified interface must be annotated with the same
-interface-modifying attribute, or with an interface-compatible one.
-
-Even then, the pragma is currently only functional when applied to
-subprograms and scalar variables; other uses, such as directly on
-types and subtypes, may be silently ignored. Specifically, it is not
-currently recommended to rely on any effects this pragma might be
-expected to have when calling subprograms through access-to-subprogram
-variables.
-
-
.. Hardened Conditionals:
Hardened Conditionals
diff --git a/gcc/ada/gcc-interface/utils.cc b/gcc/ada/gcc-interface/utils.cc
index 049cf74eb9b..038e56f25d3 100644
--- a/gcc/ada/gcc-interface/utils.cc
+++ b/gcc/ada/gcc-interface/utils.cc
@@ -94,7 +94,6 @@ static tree handle_sentinel_attribute (tree *, tree, tree, int, bool *);
static tree handle_noreturn_attribute (tree *, tree, tree, int, bool *);
static tree handle_stack_protect_attribute (tree *, tree, tree, int, bool *);
static tree handle_no_stack_protector_attribute (tree *, tree, tree, int, bool *);
-static tree handle_strub_attribute (tree *, tree, tree, int, bool *);
static tree handle_noinline_attribute (tree *, tree, tree, int, bool *);
static tree handle_noclone_attribute (tree *, tree, tree, int, bool *);
static tree handle_noicf_attribute (tree *, tree, tree, int, bool *);
@@ -158,8 +157,6 @@ const struct attribute_spec gnat_internal_attribute_table[] =
{ "no_stack_protector",0, 0, true, false, false, false,
handle_no_stack_protector_attribute,
attr_stack_protect_exclusions },
- { "strub", 0, 1, false, true, false, true,
- handle_strub_attribute, NULL },
{ "noinline", 0, 0, true, false, false, false,
handle_noinline_attribute, NULL },
{ "noclone", 0, 0, true, false, false, false,
@@ -6602,15 +6599,6 @@ handle_no_stack_protector_attribute (tree *node, tree name, tree, int,
return NULL_TREE;
}
-/* Handle a "strub" attribute; arguments as in
- struct attribute_spec.handler. */
-
-static tree
-handle_strub_attribute (tree *, tree, tree, int, bool *no_add_attrs)
-{
- *no_add_attrs = true;
- return NULL_TREE;
-}
/* Handle a "noinline" attribute; arguments as in
struct attribute_spec.handler. */
diff --git a/gcc/ada/libgnat/a-except.adb b/gcc/ada/libgnat/a-except.adb
index 3cf77126b76..31036e60126 100644
--- a/gcc/ada/libgnat/a-except.adb
+++ b/gcc/ada/libgnat/a-except.adb
@@ -629,96 +629,6 @@ package body Ada.Exceptions is
pragma No_Return (Rcheck_CE_Invalid_Data_Ext);
pragma No_Return (Rcheck_CE_Range_Check_Ext);
- -- Make all of these procedures callable from strub contexts.
- -- These attributes are not visible to callers; they are made
- -- visible in trans.c:build_raise_check.
-
- pragma Machine_Attribute (Rcheck_CE_Access_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Null_Access_Parameter,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Discriminant_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Divide_By_Zero,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Explicit_Raise,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Index_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Invalid_Data,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Length_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Null_Exception_Id,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Null_Not_Allowed,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Overflow_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Partition_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Range_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Tag_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Access_Before_Elaboration,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Accessibility_Check,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Address_Of_Intrinsic,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Aliased_Parameters,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_All_Guards_Closed,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Bad_Predicated_Generic_Type,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Build_In_Place_Mismatch,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Current_Task_In_Entry_Body,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Duplicated_Entry_Address,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Explicit_Raise,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Implicit_Return,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Misaligned_Address_Value,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Missing_Return,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Non_Transportable_Actual,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Overlaid_Controlled_Object,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Potentially_Blocking_Operation,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Stream_Operation_Not_Allowed,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Stubbed_Subprogram_Called,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Unchecked_Union_Restriction,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_PE_Finalize_Raised_Exception,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Empty_Storage_Pool,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Explicit_Raise,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Infinite_Recursion,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_SE_Object_Too_Large,
- "strub", "callable");
-
- pragma Machine_Attribute (Rcheck_CE_Access_Check_Ext,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Index_Check_Ext,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Invalid_Data_Ext,
- "strub", "callable");
- pragma Machine_Attribute (Rcheck_CE_Range_Check_Ext,
- "strub", "callable");
-
---------------------------------------------
-- Reason Strings for Run-Time Check Calls --
---------------------------------------------
diff --git a/gcc/ada/libgnat/a-except.ads b/gcc/ada/libgnat/a-except.ads
index 4411e5b1c47..2f98432a6a1 100644
--- a/gcc/ada/libgnat/a-except.ads
+++ b/gcc/ada/libgnat/a-except.ads
@@ -184,15 +184,6 @@ private
-- Raise_Exception_Always if it can determine this is the case. The Export
-- allows this routine to be accessed from Pure units.
- -- Make these callable from strub contexts.
- pragma Machine_Attribute (Raise_Exception_Always,
- "strub", "callable");
- pragma Machine_Attribute (Raise_Exception,
- "strub", "callable");
- -- This property should arguably be visible to callers, but let's
- -- keep it private for now. In practice, it doesn't matter, since
- -- it's only checked in the back end.
-
procedure Raise_From_Controlled_Operation (X : Exception_Occurrence);
pragma No_Return (Raise_From_Controlled_Operation);
pragma Export
diff --git a/gcc/ada/libgnat/s-arit128.ads b/gcc/ada/libgnat/s-arit128.ads
index b71fcd35d9a..fe043a97afb 100644
--- a/gcc/ada/libgnat/s-arit128.ads
+++ b/gcc/ada/libgnat/s-arit128.ads
@@ -167,11 +167,4 @@ is
-- then Q is the rounded quotient. The remainder R is not affected by the
-- setting of the Round flag.
-private
- -- Make it callable from strub contexts.
- -- There is a matching setting in trans.c,
- -- for calls issued by Gigi.
- pragma Machine_Attribute (Multiply_With_Ovflo_Check128,
- "strub", "callable");
-
end System.Arith_128;
diff --git a/gcc/ada/libgnat/s-arit64.ads b/gcc/ada/libgnat/s-arit64.ads
index 7ea58a48517..c4bebeb0e4e 100644
--- a/gcc/ada/libgnat/s-arit64.ads
+++ b/gcc/ada/libgnat/s-arit64.ads
@@ -179,11 +179,4 @@ is
Round : Boolean) renames Double_Divide64;
-- Renamed procedure to preserve compatibility with earlier versions
-private
- -- Make it callable from strub contexts.
- -- There is a matching setting in trans.c,
- -- for calls issued by Gigi.
- pragma Machine_Attribute (Multiply_With_Ovflo_Check64,
- "strub", "callable");
-
end System.Arith_64;
diff --git a/gcc/ada/libgnat/s-secsta.ads b/gcc/ada/libgnat/s-secsta.ads
index eaaba35e752..b75f1a3a264 100644
--- a/gcc/ada/libgnat/s-secsta.ads
+++ b/gcc/ada/libgnat/s-secsta.ads
@@ -438,9 +438,4 @@ private
function Get_Stack_Info (Stack : SS_Stack_Ptr) return Stack_Info;
-- Obtain the information attributes of secondary stack Stack
- pragma Machine_Attribute (SS_Allocate, "strub", "callable");
- pragma Machine_Attribute (SS_Mark, "strub", "callable");
- pragma Machine_Attribute (SS_Release, "strub", "callable");
- -- Enable these to be called from within strub contexts.
-
end System.Secondary_Stack;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 3:48 [gcc(refs/users/aoliva/heads/testme)] Revert "[Ada] introduce stack scrub (strub) feature" Alexandre Oliva
2022-04-06 15:02 Alexandre Oliva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).