[gcc r12-5318] fortran: Identify arguments by their names

[gcc r12-5318] fortran: Identify arguments by their names

[Mikael Morin]

https://gcc.gnu.org/g:48a8c5be5b98240d664672a2b7b7d26f3c36cf84

commit r12-5318-g48a8c5be5b98240d664672a2b7b7d26f3c36cf84
Author: Mikael Morin <mikael@gcc.gnu.org>
Date:   Sun Nov 7 14:40:36 2021 +0100

    fortran: Identify arguments by their names
    
    This provides a new function to get the name of a dummy argument,
    so that identifying an argument can be made using just its name
    instead of a mix of name matching (for keyword actual arguments)
    and argument counting (for other actual arguments).
    
    gcc/fortran/ChangeLog:
            * interface.c (gfc_dummy_arg_get_name): New function.
            * gfortran.h (gfc_dummy_arg_get_name): Declare it.
            * trans-array.c (arg_evaluated_for_scalarization): Pass a dummy
            argument wrapper as argument instead of an actual argument
            and an index number.  Check it’s non-NULL.  Use its name
            to identify it.
            (gfc_walk_elemental_function_args): Update call to
            arg_evaluated for scalarization.  Remove argument counting.

Diff:
---
 gcc/fortran/gfortran.h    |  1 +
 gcc/fortran/interface.c   | 17 +++++++++++++++++
 gcc/fortran/trans-array.c | 16 +++++-----------
 3 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h
index bf617705827..1846ee4fd3c 100644
--- a/gcc/fortran/gfortran.h
+++ b/gcc/fortran/gfortran.h
@@ -2329,6 +2329,7 @@ struct gfc_dummy_arg
 #define gfc_get_dummy_arg() XCNEW (gfc_dummy_arg)
 
 
+const char * gfc_dummy_arg_get_name (gfc_dummy_arg &);
 const gfc_typespec & gfc_dummy_arg_get_typespec (gfc_dummy_arg &);
 bool gfc_dummy_arg_is_optional (gfc_dummy_arg &);
 
diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c
index 12574f8f037..85717096103 100644
--- a/gcc/fortran/interface.c
+++ b/gcc/fortran/interface.c
@@ -5534,6 +5534,23 @@ gfc_get_formal_from_actual_arglist (gfc_symbol *sym,
 }
 
 
+const char *
+gfc_dummy_arg_get_name (gfc_dummy_arg & dummy_arg)
+{
+  switch (dummy_arg.intrinsicness)
+    {
+    case GFC_INTRINSIC_DUMMY_ARG:
+      return dummy_arg.u.intrinsic->name;
+
+    case GFC_NON_INTRINSIC_DUMMY_ARG:
+      return dummy_arg.u.non_intrinsic->sym->name;
+
+    default:
+      gcc_unreachable ();
+    }
+}
+
+
 const gfc_typespec &
 gfc_dummy_arg_get_typespec (gfc_dummy_arg & dummy_arg)
 {
diff --git a/gcc/fortran/trans-array.c b/gcc/fortran/trans-array.c
index d37c1e7ad7f..2090adf01e7 100644
--- a/gcc/fortran/trans-array.c
+++ b/gcc/fortran/trans-array.c
@@ -11492,16 +11492,14 @@ gfc_get_intrinsic_for_expr (gfc_expr *call)
 
 static bool
 arg_evaluated_for_scalarization (gfc_intrinsic_sym *function,
-				 gfc_actual_arglist &actual_arg, int arg_num)
+				 gfc_dummy_arg *dummy_arg)
 {
-  if (function != NULL)
+  if (function != NULL && dummy_arg != NULL)
     {
       switch (function->id)
 	{
 	  case GFC_ISYM_INDEX:
-	    if ((actual_arg.name == NULL && arg_num == 3)
-		|| (actual_arg.name != NULL
-		    && strcmp ("kind", actual_arg.name) == 0))
+	    if (strcmp ("kind", gfc_dummy_arg_get_name (*dummy_arg)) == 0)
 	      return false;
 	  /* Fallthrough.  */
 
@@ -11532,15 +11530,14 @@ gfc_walk_elemental_function_args (gfc_ss * ss, gfc_actual_arglist *arg,
   head = gfc_ss_terminator;
   tail = NULL;
 
-  int arg_num = 0;
   scalar = 1;
   for (; arg; arg = arg->next)
     {
       gfc_dummy_arg * const dummy_arg = arg->associated_dummy;
       if (!arg->expr
 	  || arg->expr->expr_type == EXPR_NULL
-	  || !arg_evaluated_for_scalarization (intrinsic_sym, *arg, arg_num))
-	goto loop_continue;
+	  || !arg_evaluated_for_scalarization (intrinsic_sym, dummy_arg))
+	continue;
 
       newss = gfc_walk_subexpr (head, arg->expr);
       if (newss == head)
@@ -11570,9 +11567,6 @@ gfc_walk_elemental_function_args (gfc_ss * ss, gfc_actual_arglist *arg,
           while (tail->next != gfc_ss_terminator)
             tail = tail->next;
         }
-
-loop_continue:
-      arg_num++;
     }
 
   if (scalar)