public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-5434] Fix ignore_nondeterminism_p in ipa-modref
@ 2021-11-20 23:40 Jan Hubicka
  0 siblings, 0 replies; only message in thread
From: Jan Hubicka @ 2021-11-20 23:40 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:ce2dbf943ac8ffefe048016ac3abfd3b6a4518d4

commit r12-5434-gce2dbf943ac8ffefe048016ac3abfd3b6a4518d4
Author: Jan Hubicka <jh@suse.cz>
Date:   Sun Nov 21 00:39:42 2021 +0100

    Fix ignore_nondeterminism_p in ipa-modref
    
    Improve debug output in ipa-modref and fix ignore_nondeterminism predicate:
    looping pures and cont are still deterministic.
    
    gcc/ChangeLog:
    
    2021-11-21  Jan Hubicka  <hubicka@ucw.cz>
    
            PR ipa/103052
            * ipa-modref.c (ignore_nondeterminism_p): Allow looping pure/cont.
            (merge_call_side_effects): Improve debug output.

Diff:
---
 gcc/ipa-modref.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index 57e2aa5d868..20810c74da5 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -923,8 +923,7 @@ record_access_p (tree expr)
 static bool
 ignore_nondeterminism_p (tree caller, int flags)
 {
-  if ((flags & (ECF_CONST | ECF_PURE))
-      && !(flags & ECF_LOOPING_CONST_OR_PURE))
+  if (flags & (ECF_CONST | ECF_PURE))
     return true;
   if ((flags & (ECF_NORETURN | ECF_NOTHROW)) == (ECF_NORETURN | ECF_NOTHROW)
       || (!opt_for_fn (caller, flag_exceptions) && (flags & ECF_NORETURN)))
@@ -1016,6 +1015,10 @@ merge_call_side_effects (modref_summary *cur_summary,
       && !(flags & ECF_LOOPING_CONST_OR_PURE))
     return changed;
 
+  if (dump_file)
+    fprintf (dump_file, " - Merging side effects of %s\n",
+	     callee_node->dump_name ());
+
   if (!(flags & (ECF_CONST | ECF_NOVOPS | ECF_PURE))
       || (flags & ECF_LOOPING_CONST_OR_PURE))
     {
@@ -1061,8 +1064,7 @@ merge_call_side_effects (modref_summary *cur_summary,
     }
 
   if (dump_file)
-    fprintf (dump_file, " - Merging side effects of %s with parm map:",
-	     callee_node->dump_name ());
+    fprintf (dump_file, "   Parm map:");
 
   parm_map.safe_grow_cleared (gimple_call_num_args (stmt), true);
   for (unsigned i = 0; i < gimple_call_num_args (stmt); i++)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-20 23:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-20 23:40 [gcc r12-5434] Fix ignore_nondeterminism_p in ipa-modref Jan Hubicka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).