public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-9327] openmp: For default(none) ignore variables created by ubsan_create_data [PR64888]
@ 2021-11-29 8:49 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2021-11-29 8:49 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:930ffe933186b66ee33479fe384d4aa08e9f7459
commit r11-9327-g930ffe933186b66ee33479fe384d4aa08e9f7459
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Oct 21 10:27:44 2021 +0200
openmp: For default(none) ignore variables created by ubsan_create_data [PR64888]
We weren't ignoring the ubsan variables created by c-ubsan.c before gimplification
(others are added later). One way to fix this would be to introduce further
UBSAN_ internal functions and lower it later (sanopt pass) like other ifns,
this patch instead recognizes those magic vars by name/name of type and DECL_ARTIFICIAL
and TYPE_ARTIFICIAL.
2021-10-21 Jakub Jelinek <jakub@redhat.com>
PR middle-end/64888
gcc/c-family/
* c-omp.c (c_omp_predefined_variable): Return true also for
ubsan_create_data created artificial variables.
gcc/testsuite/
* c-c++-common/ubsan/pr64888.c: New test.
(cherry picked from commit 40dd9d839e52f679d8eabc1c5ca0ca17a5ccfd14)
Diff:
---
gcc/c-family/c-omp.c | 43 +++++++++++++++++++++++++-----
gcc/testsuite/c-c++-common/ubsan/pr64888.c | 27 +++++++++++++++++++
2 files changed, 64 insertions(+), 6 deletions(-)
diff --git a/gcc/c-family/c-omp.c b/gcc/c-family/c-omp.c
index fb1a0d6041e..d58faa9f468 100644
--- a/gcc/c-family/c-omp.c
+++ b/gcc/c-family/c-omp.c
@@ -2551,13 +2551,44 @@ c_omp_predefined_variable (tree decl)
{
if (VAR_P (decl)
&& DECL_ARTIFICIAL (decl)
- && TREE_READONLY (decl)
&& TREE_STATIC (decl)
- && DECL_NAME (decl)
- && (DECL_NAME (decl) == ridpointers[RID_C99_FUNCTION_NAME]
- || DECL_NAME (decl) == ridpointers[RID_FUNCTION_NAME]
- || DECL_NAME (decl) == ridpointers[RID_PRETTY_FUNCTION_NAME]))
- return true;
+ && DECL_NAME (decl))
+ {
+ if (TREE_READONLY (decl)
+ && (DECL_NAME (decl) == ridpointers[RID_C99_FUNCTION_NAME]
+ || DECL_NAME (decl) == ridpointers[RID_FUNCTION_NAME]
+ || DECL_NAME (decl) == ridpointers[RID_PRETTY_FUNCTION_NAME]))
+ return true;
+ /* For UBSan handle the same also ubsan_create_data created
+ variables. There is no magic flag for those, but user variables
+ shouldn't be DECL_ARTIFICIAL or have TYPE_ARTIFICIAL type with
+ such names. */
+ if ((flag_sanitize & (SANITIZE_UNDEFINED
+ | SANITIZE_UNDEFINED_NONDEFAULT)) != 0
+ && DECL_IGNORED_P (decl)
+ && !TREE_READONLY (decl)
+ && TREE_CODE (DECL_NAME (decl)) == IDENTIFIER_NODE
+ && TREE_CODE (TREE_TYPE (decl)) == RECORD_TYPE
+ && TYPE_ARTIFICIAL (TREE_TYPE (decl))
+ && TYPE_NAME (TREE_TYPE (decl))
+ && TREE_CODE (TYPE_NAME (TREE_TYPE (decl))) == TYPE_DECL
+ && DECL_NAME (TYPE_NAME (TREE_TYPE (decl)))
+ && (TREE_CODE (DECL_NAME (TYPE_NAME (TREE_TYPE (decl))))
+ == IDENTIFIER_NODE))
+ {
+ tree id1 = DECL_NAME (decl);
+ tree id2 = DECL_NAME (TYPE_NAME (TREE_TYPE (decl)));
+ if (IDENTIFIER_LENGTH (id1) >= sizeof ("ubsan_data") - 1
+ && IDENTIFIER_LENGTH (id2) >= sizeof ("__ubsan__data")
+ && !memcmp (IDENTIFIER_POINTER (id2), "__ubsan_",
+ sizeof ("__ubsan_") - 1)
+ && !memcmp (IDENTIFIER_POINTER (id2) + IDENTIFIER_LENGTH (id2)
+ - sizeof ("_data") + 1, "_data",
+ sizeof ("_data") - 1)
+ && strstr (IDENTIFIER_POINTER (id1), "ubsan_data"))
+ return true;
+ }
+ }
return false;
}
diff --git a/gcc/testsuite/c-c++-common/ubsan/pr64888.c b/gcc/testsuite/c-c++-common/ubsan/pr64888.c
new file mode 100644
index 00000000000..6319c2feced
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/ubsan/pr64888.c
@@ -0,0 +1,27 @@
+/* PR middle-end/64888 */
+/* { dg-do compile { target fopenmp } } */
+/* { dg-options "-fopenmp -fsanitize=undefined" } */
+
+int a, b;
+
+void
+foo ()
+{
+ int c;
+#pragma omp parallel default (none) shared (a, b) private (c)
+ {
+ c = a / b; /* { dg-bogus "not specified in enclosing" } */
+ (void) c;
+ }
+#pragma omp task default (none) shared (a, b) private (c)
+ {
+ c = a << b; /* { dg-bogus "not specified in enclosing" } */
+ (void) c;
+ }
+#pragma omp teams default (none) shared (a, b)
+ {
+ int d[a]; /* { dg-bogus "not specified in enclosing" } */
+ d[0] = 0;
+ (void) d[0];
+ }
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-11-29 8:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 8:49 [gcc r11-9327] openmp: For default(none) ignore variables created by ubsan_create_data [PR64888] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).