public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-9331] i386: Fix up x86 atomic_bit_test* expanders for !TARGET_HIMODE_MATH [PR103205]
@ 2021-11-29  8:49 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2021-11-29  8:49 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:5950a9c5ff3a324d82883983032a32504f4c56fe

commit r11-9331-g5950a9c5ff3a324d82883983032a32504f4c56fe
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Nov 15 09:30:08 2021 +0100

    i386: Fix up x86 atomic_bit_test* expanders for !TARGET_HIMODE_MATH [PR103205]
    
    With !TARGET_HIMODE_MATH, the OPTAB_DIRECT expand_simple_binop fail and so
    we ICE.  We don't really care if they are done promoted in SImode instead.
    
    2021-11-15  Jakub Jelinek  <jakub@redhat.com>
    
            PR target/103205
            * config/i386/sync.md (atomic_bit_test_and_set<mode>,
            atomic_bit_test_and_complement<mode>,
            atomic_bit_test_and_reset<mode>): Use OPTAB_WIDEN instead of
            OPTAB_DIRECT.
    
            * gcc.target/i386/pr103205.c: New test.
    
    (cherry picked from commit 625eef42e32e65b3da0e65e23a706d228896d01c)

Diff:
---
 gcc/config/i386/sync.md                  |  6 +++---
 gcc/testsuite/gcc.target/i386/pr103205.c | 11 +++++++++++
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/gcc/config/i386/sync.md b/gcc/config/i386/sync.md
index 05a835256bb..9716a0b2f2c 100644
--- a/gcc/config/i386/sync.md
+++ b/gcc/config/i386/sync.md
@@ -726,7 +726,7 @@
   rtx result = convert_modes (<MODE>mode, QImode, tem, 1);
   if (operands[4] == const0_rtx)
     result = expand_simple_binop (<MODE>mode, ASHIFT, result,
-				  operands[2], operands[0], 0, OPTAB_DIRECT);
+				  operands[2], operands[0], 0, OPTAB_WIDEN);
   if (result != operands[0])
     emit_move_insn (operands[0], result);
   DONE;
@@ -763,7 +763,7 @@
   rtx result = convert_modes (<MODE>mode, QImode, tem, 1);
   if (operands[4] == const0_rtx)
     result = expand_simple_binop (<MODE>mode, ASHIFT, result,
-				  operands[2], operands[0], 0, OPTAB_DIRECT);
+				  operands[2], operands[0], 0, OPTAB_WIDEN);
   if (result != operands[0])
     emit_move_insn (operands[0], result);
   DONE;
@@ -801,7 +801,7 @@
   rtx result = convert_modes (<MODE>mode, QImode, tem, 1);
   if (operands[4] == const0_rtx)
     result = expand_simple_binop (<MODE>mode, ASHIFT, result,
-				  operands[2], operands[0], 0, OPTAB_DIRECT);
+				  operands[2], operands[0], 0, OPTAB_WIDEN);
   if (result != operands[0])
     emit_move_insn (operands[0], result);
   DONE;
diff --git a/gcc/testsuite/gcc.target/i386/pr103205.c b/gcc/testsuite/gcc.target/i386/pr103205.c
new file mode 100644
index 00000000000..eaeea82fee2
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr103205.c
@@ -0,0 +1,11 @@
+/* PR target/103205 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -mtune-ctrl=^himode_math" } */
+
+unsigned short a;
+
+unsigned short
+foo (void)
+{
+  return __sync_fetch_and_and (&a, ~1) & 1;
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-29  8:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29  8:49 [gcc r11-9331] i386: Fix up x86 atomic_bit_test* expanders for !TARGET_HIMODE_MATH [PR103205] Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).