public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-5596] c++: Small incremental tweak to source_location::current() folding
@ 2021-11-30  8:50 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2021-11-30  8:50 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:2af2f55a500adad73451f3b859cfaa8974920caf

commit r12-5596-g2af2f55a500adad73451f3b859cfaa8974920caf
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Nov 30 09:48:59 2021 +0100

    c++: Small incremental tweak to source_location::current() folding
    
    I've already committed the patch, but perhaps we shouldn't do it in cp_fold
    where it will be folded even for warnings etc. and the locations might not
    be the final yet.  This patch moves it to cp_fold_r so that it is done just
    once for each function and just once for each static initializer.
    
    2021-11-30  Jakub Jelinek  <jakub@redhat.com>
    
            * cp-gimplify.c (cp_fold_r): Perform folding of
            std::source_location::current() calls here...
            (cp_fold): ... rather than here.

Diff:
---
 gcc/cp/cp-gimplify.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/gcc/cp/cp-gimplify.c b/gcc/cp/cp-gimplify.c
index 2fbb4236b92..0988655eeba 100644
--- a/gcc/cp/cp-gimplify.c
+++ b/gcc/cp/cp-gimplify.c
@@ -930,6 +930,13 @@ cp_fold_r (tree *stmt_p, int *walk_subtrees, void *data)
 	}
       break;
 
+    case CALL_EXPR:
+      if (tree fndecl = cp_get_callee_fndecl_nofold (stmt))
+	if (DECL_IMMEDIATE_FUNCTION_P (fndecl)
+	    && source_location_current_p (fndecl))
+	  *stmt_p = stmt = cxx_constant_value (stmt);
+      break;
+
     default:
       break;
     }
@@ -2672,14 +2679,6 @@ cp_fold (tree x)
 	int sv = optimize, nw = sv;
 	tree callee = get_callee_fndecl (x);
 
-	if (tree fndecl = cp_get_callee_fndecl_nofold (x))
-	  if (DECL_IMMEDIATE_FUNCTION_P (fndecl)
-	      && source_location_current_p (fndecl))
-	    {
-	      x = cxx_constant_value (x);
-	      break;
-	    }
-
 	/* Some built-in function calls will be evaluated at compile-time in
 	   fold ().  Set optimize to 1 when folding __builtin_constant_p inside
 	   a constexpr function so that fold_builtin_1 doesn't fold it to 0.  */


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-30  8:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30  8:50 [gcc r12-5596] c++: Small incremental tweak to source_location::current() folding Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).