public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: William Schmidt <wschmidt@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5646] rs6000: Clarify overloaded builtin diagnostic Date: Tue, 30 Nov 2021 23:20:56 +0000 (GMT) [thread overview] Message-ID: <20211130232056.E41623858403@sourceware.org> (raw) https://gcc.gnu.org/g:0fc26e6f0b5e5a40f2649e98db605f4c740e2c4e commit r12-5646-g0fc26e6f0b5e5a40f2649e98db605f4c740e2c4e Author: Bill Schmidt <wschmidt@linux.ibm.com> Date: Tue Nov 23 10:22:58 2021 -0600 rs6000: Clarify overloaded builtin diagnostic When a built-in function required by an overloaded function name is not currently enabled, the diagnostic message is not as clear as it should be. Saying that one built-in "requires" another is somewhat misleading. It is better to explicitly state that the overloaded builtin is implemented by the missing builtin. 2021-11-23 Bill Schmidt <wschmidt@linux.ibm.com> gcc/ * config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin): Clarify diagnostic. (altivec_resolve_new_overloaded_builtin): Likewise. Diff: --- gcc/config/rs6000/rs6000-c.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gcc/config/rs6000/rs6000-c.c b/gcc/config/rs6000/rs6000-c.c index d08bdfec3ae..5eeac9d4c06 100644 --- a/gcc/config/rs6000/rs6000-c.c +++ b/gcc/config/rs6000/rs6000-c.c @@ -1946,7 +1946,8 @@ altivec_resolve_overloaded_builtin (location_t loc, tree fndecl, non-overloaded function has already been issued. Add clarification of the previous message. */ rich_location richloc (line_table, input_location); - inform (&richloc, "builtin %qs requires builtin %qs", + inform (&richloc, + "overloaded builtin %qs is implemented by builtin %qs", name, internal_name); } else @@ -2992,7 +2993,8 @@ altivec_resolve_new_overloaded_builtin (location_t loc, tree fndecl, non-overloaded function has already been issued. Add clarification of the previous message. */ rich_location richloc (line_table, input_location); - inform (&richloc, "builtin %qs requires builtin %qs", + inform (&richloc, + "overloaded builtin %qs is implemented by builtin %qs", name, internal_name); } else
reply other threads:[~2021-11-30 23:20 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211130232056.E41623858403@sourceware.org \ --to=wschmidt@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).