public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-6321] x86: Generate INT3 for __builtin_eh_return
@ 2022-01-06 19:53 H.J. Lu
  0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2022-01-06 19:53 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:c2e5c4feed32c808591b5278f680bbabe63eb225

commit r12-6321-gc2e5c4feed32c808591b5278f680bbabe63eb225
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Jan 5 18:04:21 2022 -0800

    x86: Generate INT3 for __builtin_eh_return
    
    Generate INT3 after indirect jmp in exception return for -fcf-protection
    with -mharden-sls=indirect-jmp.
    
    gcc/
    
            PR target/103925
            * config/i386/i386.c (ix86_output_indirect_function_return):
            Generate INT3 after indirect jmp for -mharden-sls=indirect-jmp.
    
    gcc/testsuite/
    
            PR target/103925
            * gcc.target/i386/harden-sls-6.c: New test.

Diff:
---
 gcc/config/i386/i386.c                       |  9 ++++++---
 gcc/testsuite/gcc.target/i386/harden-sls-6.c | 18 ++++++++++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 736577585f7..c4ed82d0446 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -16382,11 +16382,14 @@ ix86_output_indirect_function_return (rtx ret_op)
 	}
       else
 	output_indirect_thunk (regno);
-
-      return "";
     }
   else
-    return "%!jmp\t%A0";
+    {
+      output_asm_insn ("%!jmp\t%A0", &ret_op);
+      if (ix86_harden_sls & harden_sls_indirect_jmp)
+	fputs ("\tint3\n", asm_out_file);
+    }
+  return "";
 }
 
 /* Output the assembly for a call instruction.  */
diff --git a/gcc/testsuite/gcc.target/i386/harden-sls-6.c b/gcc/testsuite/gcc.target/i386/harden-sls-6.c
new file mode 100644
index 00000000000..9068eb64008
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/harden-sls-6.c
@@ -0,0 +1,18 @@
+/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-options "-O2 -fcf-protection -mharden-sls=indirect-jmp" } */
+
+struct _Unwind_Context _Unwind_Resume_or_Rethrow_this_context;
+
+void offset (int);
+
+struct _Unwind_Context {
+  void *reg[7];
+} _Unwind_Resume_or_Rethrow() {
+  struct _Unwind_Context cur_contextcur_context =
+      _Unwind_Resume_or_Rethrow_this_context;
+  offset(0);
+  __builtin_eh_return ((long) offset, 0);
+}
+
+/* { dg-final { scan-assembler "jmp\[ \t\]+\\*%rcx" } } */
+/* { dg-final { scan-assembler-times "int3" 1 } } */


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-06 19:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 19:53 [gcc r12-6321] x86: Generate INT3 for __builtin_eh_return H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).