[gcc r12-6596] Fortran: always reject alternate return specifier as argument of intrinsics

[gcc r12-6596] Fortran: always reject alternate return specifier as argument of intrinsics

[Harald Anlauf]

https://gcc.gnu.org/g:70e24c9682ddbcade0301665bccd8e7f928d0082

commit r12-6596-g70e24c9682ddbcade0301665bccd8e7f928d0082
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Fri Jan 14 21:48:15 2022 +0100

    Fortran: always reject alternate return specifier as argument of intrinsics
    
    The intrinsics MOVE_ALLOC, C_F_POINTER, and C_F_PROCPOINTER require
    deferred checks of part of their actual argument types which may be of
    "any" type.  This however excludes alternate return specifiers which
    therefore must be unconditionally rejected for all standard intrinsics.
    
    gcc/fortran/ChangeLog:
    
            PR fortran/99256
            * intrinsic.c: Do not check formal argument type when checking
            arguments of intrinsics for alternate return specifiers.
    
    gcc/testsuite/ChangeLog:
    
            PR fortran/99256
            * gfortran.dg/altreturn_11.f90: New test.

Diff:
---
 gcc/fortran/intrinsic.c                    |  2 +-
 gcc/testsuite/gfortran.dg/altreturn_11.f90 | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/gcc/fortran/intrinsic.c b/gcc/fortran/intrinsic.c
index a7ecdb401ef..9746cd5ddb6 100644
--- a/gcc/fortran/intrinsic.c
+++ b/gcc/fortran/intrinsic.c
@@ -4420,7 +4420,7 @@ do_sort:
   FOR_EACH_VEC_ELT (dummy_args, idx, f)
     {
       a = ordered_actual_args[idx];
-      if (a && a->label != NULL && f->ts.type)
+      if (a && a->label != NULL)
 	{
 	  gfc_error ("ALTERNATE RETURN not permitted at %L", where);
 	  return false;
diff --git a/gcc/testsuite/gfortran.dg/altreturn_11.f90 b/gcc/testsuite/gfortran.dg/altreturn_11.f90
new file mode 100644
index 00000000000..be42971d781
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/altreturn_11.f90
@@ -0,0 +1,15 @@
+! { dg-do compile }
+! { dg-prune-output "Obsolescent feature: Alternate-return argument" }
+! PR fortran/99256 - ICE in variable_check
+! Contributed by G.Steimetz
+
+program test
+  use iso_c_binding
+  type(c_ptr)    :: i
+  type(c_funptr) :: p
+  call move_alloc     (*1, *2) ! { dg-error "ALTERNATE RETURN" }
+  call c_f_pointer     (i, *1) ! { dg-error "ALTERNATE RETURN" }
+  call c_f_procpointer (p, *2) ! { dg-error "ALTERNATE RETURN" }
+1 continue
+2 stop
+end