public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-6877] rtl: builtins: Fix builtins feclearexcept and feraiseexcept operand check [PR94193]
@ 2022-01-26 15:21 Segher Boessenkool
  0 siblings, 0 replies; only message in thread
From: Segher Boessenkool @ 2022-01-26 15:21 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:8bcf835e0a4e3334e1c60f314ae6917ba648bdde

commit r12-6877-g8bcf835e0a4e3334e1c60f314ae6917ba648bdde
Author: Raoni Fassina Firmino <raoni@linux.ibm.com>
Date:   Wed Jan 26 12:05:54 2022 -0300

    rtl: builtins: Fix builtins feclearexcept and feraiseexcept operand check [PR94193]
    
    Commit 4343f5e25679 ("rtl: builtins: (not just) rs6000: Add builtins
    for fegetround, feclearexcept and feraiseexcept [PR94193]") broke gcc
    bootstra when building with --enable-checking=rtl[1].
    
    The function expand_builtin_feclear_feraise_except was failing to
    proper validate op0 predicate before emit_insn leading to the mismatch
    type failure.
    
    [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-January/589186.html
    
    2022-01-26  Raoni Fassina Firmino  <raoni@linux.ibm.com>
    
    gcc/
            PR target/94193
            * builtins.cc (expand_builtin_feclear_feraise_except): Add op0
            predicate check.
    
    Signed-off-by: Raoni Fassina Firmino <raoni@linux.ibm.com>

Diff:
---
 gcc/builtins.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gcc/builtins.cc b/gcc/builtins.cc
index e84208035da..d784a57c2b8 100644
--- a/gcc/builtins.cc
+++ b/gcc/builtins.cc
@@ -2598,6 +2598,9 @@ expand_builtin_feclear_feraise_except (tree exp, rtx target,
   if (icode == CODE_FOR_nothing)
     return NULL_RTX;
 
+  if (!(*insn_data[icode].operand[1].predicate) (op0, GET_MODE (op0)))
+    return NULL_RTX;
+
   if (target == 0
       || GET_MODE (target) != target_mode
       || !(*insn_data[icode].operand[0].predicate) (target, target_mode))


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-26 15:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 15:21 [gcc r12-6877] rtl: builtins: Fix builtins feclearexcept and feraiseexcept operand check [PR94193] Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).