public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-7024] ranger: fix small thinko in fur_list constructor
@ 2022-02-03 14:49 Aldy Hernandez
  0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-02-03 14:49 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:f544e5efaf2747ee2add3d408cc2f216433ba617

commit r12-7024-gf544e5efaf2747ee2add3d408cc2f216433ba617
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Thu Feb 3 15:45:55 2022 +0100

    ranger: fix small thinko in fur_list constructor
    
    The fur_list constructor for two ranges is leaving [1] in an undefined
    state.  The reason we haven't noticed is because after all the
    shuffling in the last cycle there are no remaining users of it
    (similarly for fur_list(unsigned, irange *)).
    
    Since it's very late in the cycle, I would prefer to fix this, rather
    than removing unused constructors altogether.  Besides, we have uses
    of them queued up for the next release.
    
    gcc/ChangeLog:
    
            * gimple-range-fold.cc (fur_list::fur_list): Set m_local[1] correctly.

Diff:
---
 gcc/gimple-range-fold.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/gimple-range-fold.cc b/gcc/gimple-range-fold.cc
index d70f6a2e8c8..5133a430f25 100644
--- a/gcc/gimple-range-fold.cc
+++ b/gcc/gimple-range-fold.cc
@@ -243,7 +243,7 @@ fur_list::fur_list (irange &r1, irange &r2) : fur_source (NULL)
   m_index = 0;
   m_limit = 2;
   m_local[0] = r1;
-  m_local[0] = r2;
+  m_local[1] = r2;
 }
 
 // Arbitrary number of ranges in a vector.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-03 14:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-03 14:49 [gcc r12-7024] ranger: fix small thinko in fur_list constructor Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).