public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-7168] nvptx: Tweak constraints on copysign instructions
@ 2022-02-10 8:02 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-02-10 8:02 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:6d98e83b2c919bd9fba2c61333d613bafc37357f
commit r12-7168-g6d98e83b2c919bd9fba2c61333d613bafc37357f
Author: Roger Sayle <roger@nextmovesoftware.com>
Date: Tue Feb 8 20:56:55 2022 +0100
nvptx: Tweak constraints on copysign instructions
Many thanks to Thomas Schwinge for confirming my hypothesis that the register
usage regression, PR target/104345, is solely due to libgcc's _muldc3 function.
In addition to the isinf functionality in the previously proposed nvptx patch at
https://gcc.gnu.org/pipermail/gcc-patches/2022-January/588453.html which
significantly reduces the number of instructions in _muldc3, the patch below
further reduces both the number of instructions and the number of explicitly
declared registers, by permitting floating point constant immediate operands
in nvptx's copysign instruction.
Fingers-crossed, the combination with all of the previous proposed nvptx
patches improves things. Ultimately, increasing register usage from 50 to
51 registers, reducing the number of concurrent threads by ~2%, can easily
be countered if we're now executing significantly fewer instructions in each
kernel, for a net performance win.
This patch has been tested on nvptx-none hosted on x86_64-pc-linux-gnu
with a "make" and "make -k check" with no new failures.
gcc/ChangeLog:
* config/nvptx/nvptx.md (copysign<mode>3): Allow immediate
floating point constants as operands 1 and/or 2.
Diff:
---
gcc/config/nvptx/nvptx.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/config/nvptx/nvptx.md b/gcc/config/nvptx/nvptx.md
index ad642e78ae3..bb0c0b3b9a5 100644
--- a/gcc/config/nvptx/nvptx.md
+++ b/gcc/config/nvptx/nvptx.md
@@ -1209,8 +1209,8 @@
(define_insn "copysign<mode>3"
[(set (match_operand:SDFM 0 "nvptx_register_operand" "=R")
- (unspec:SDFM [(match_operand:SDFM 1 "nvptx_register_operand" "R")
- (match_operand:SDFM 2 "nvptx_register_operand" "R")]
+ (unspec:SDFM [(match_operand:SDFM 1 "nvptx_nonmemory_operand" "RF")
+ (match_operand:SDFM 2 "nvptx_nonmemory_operand" "RF")]
UNSPEC_COPYSIGN))]
""
"%.\\tcopysign%t0\\t%0, %2, %1;")
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-10 8:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 8:02 [gcc r12-7168] nvptx: Tweak constraints on copysign instructions Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).