public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-7412] c++: ICE with attribute on enumerator [PR104667]
@ 2022-02-28 16:32 Marek Polacek
0 siblings, 0 replies; only message in thread
From: Marek Polacek @ 2022-02-28 16:32 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:c8b0571e334792c0c789438617cfb7faf86ab599
commit r12-7412-gc8b0571e334792c0c789438617cfb7faf86ab599
Author: Marek Polacek <polacek@redhat.com>
Date: Thu Feb 24 16:41:53 2022 -0500
c++: ICE with attribute on enumerator [PR104667]
When processing a template, the enumerators we build don't have a type
yet. But is_late_template_attribute is not prepared to see a _DECL
without a type, so we crash on
enum tree_code code = TREE_CODE (type);
(I found that we don't give the "is deprecated" warning for the enumerator
'f' in the test. Reported as PR104682.)
PR c++/104667
gcc/cp/ChangeLog:
* decl2.cc (is_late_template_attribute): Cope with a decl without
a type.
gcc/testsuite/ChangeLog:
* g++.dg/ext/attrib64.C: New test.
Diff:
---
gcc/cp/decl2.cc | 3 +++
gcc/testsuite/g++.dg/ext/attrib64.C | 11 +++++++++++
2 files changed, 14 insertions(+)
diff --git a/gcc/cp/decl2.cc b/gcc/cp/decl2.cc
index 2e58419ea51..22edc2ba7f9 100644
--- a/gcc/cp/decl2.cc
+++ b/gcc/cp/decl2.cc
@@ -1298,6 +1298,9 @@ is_late_template_attribute (tree attr, tree decl)
{
tree type = TYPE_P (decl) ? decl : TREE_TYPE (decl);
+ if (!type)
+ return true;
+
/* We can't apply any attributes to a completely unknown type until
instantiation time. */
enum tree_code code = TREE_CODE (type);
diff --git a/gcc/testsuite/g++.dg/ext/attrib64.C b/gcc/testsuite/g++.dg/ext/attrib64.C
new file mode 100644
index 00000000000..4a4505fc4b2
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/attrib64.C
@@ -0,0 +1,11 @@
+// PR c++/104667
+// { dg-do compile }
+
+template<typename> struct A {
+ enum E { // { dg-warning "only applies to function types" }
+ e __attribute__ ((access(read_only))),
+ f __attribute__ ((deprecated))
+ };
+};
+
+A<int> a;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-28 16:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-28 16:32 [gcc r12-7412] c++: ICE with attribute on enumerator [PR104667] Marek Polacek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).