public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-7432] tree-optimization/104716 - check if we can copy loop in loop distribution Date: Tue, 1 Mar 2022 14:25:50 +0000 (GMT) [thread overview] Message-ID: <20220301142550.534DE385841C@sourceware.org> (raw) https://gcc.gnu.org/g:54ef95cc4d1f3f2cde7c1f13250f889ffb81ca75 commit r12-7432-g54ef95cc4d1f3f2cde7c1f13250f889ffb81ca75 Author: Richard Biener <rguenther@suse.de> Date: Tue Mar 1 09:24:26 2022 +0100 tree-optimization/104716 - check if we can copy loop in loop distribution The following checks whether we can copy the loop before attempting to do so in loop distribution. In the testcase there's a computed goto and thus abnormal edges which we cannot redirect. 2022-03-01 Richard Biener <rguenther@suse.de> PR tree-optimization/104716 * tree-loop-distribution.cc (find_seed_stmts_for_distribution): Check if we can copy the loop. * gfortran.dg/pr104716.f: New testcase. Diff: --- gcc/testsuite/gfortran.dg/pr104716.f | 31 +++++++++++++++++++++++++++++++ gcc/tree-loop-distribution.cc | 9 ++++++++- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gfortran.dg/pr104716.f b/gcc/testsuite/gfortran.dg/pr104716.f new file mode 100644 index 00000000000..97f899a9201 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr104716.f @@ -0,0 +1,31 @@ +! { dg-do compile } +! { dg-options "-std=legacy -O2 -ftree-loop-distribution -fno-move-loop-stores -fno-tree-dominator-opts" } + + SUBROUTINE FOO() + + COMMON /WORK/ C2(2, 2) + + DIMENSION D11(2) + + EQUIVALENCE (D11(1), C2(1, 1)) + + DO 40 I = 1, 2 + DO 30 J = 1, 2 + ASSIGN 10 TO ILBL + IF (C2(J, I) .NE. 0.0) THEN + ASSIGN 20 TO ILBL + ENDIF + GO TO ILBL + 10 CONTINUE + 20 CONTINUE + C2(J, I) = C2(J, I) + 1 + 30 CONTINUE + 40 CONTINUE + + DO 50 I = 1, 2 + PRINT 90, I + 50 CONTINUE + + RETURN + 90 FORMAT(I5) + END diff --git a/gcc/tree-loop-distribution.cc b/gcc/tree-loop-distribution.cc index 8ee40d88816..db6e9096a86 100644 --- a/gcc/tree-loop-distribution.cc +++ b/gcc/tree-loop-distribution.cc @@ -3277,8 +3277,15 @@ find_seed_stmts_for_distribution (class loop *loop, vec<gimple *> *work_list) work_list->safe_push (stmt); } } + bool res = work_list->length () > 0; + if (res && !can_copy_bbs_p (bbs, loop->num_nodes)) + { + if (dump_file && (dump_flags & TDF_DETAILS)) + fprintf (dump_file, "cannot copy loop %d.\n", loop->num); + res = false; + } free (bbs); - return work_list->length () > 0; + return res; } /* A helper function for generate_{rawmemchr,strlen}_builtin functions in order
reply other threads:[~2022-03-01 14:25 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220301142550.534DE385841C@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).